Return-Path: 
 <tomcat-dev-return-51033-apmail-jakarta-tomcat-dev-archive=jakarta.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-tomcat-dev-archive@www.apache.org
Received: (qmail 62054 invoked from network); 5 Oct 2004 00:26:03 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur-2.apache.org with SMTP; 5 Oct 2004 00:26:03 -0000
Received: (qmail 36742 invoked by uid 500); 5 Oct 2004 00:25:46 -0000
Delivered-To: apmail-jakarta-tomcat-dev-archive@jakarta.apache.org
Received: (qmail 36679 invoked by uid 500); 5 Oct 2004 00:25:45 -0000
Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
List-Subscribe: <mailto:tomcat-dev-subscribe@jakarta.apache.org>
List-Help: <mailto:tomcat-dev-help@jakarta.apache.org>
List-Post: <mailto:tomcat-dev@jakarta.apache.org>
List-Id: "Tomcat Developers List" <tomcat-dev.jakarta.apache.org>
Reply-To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
Delivered-To: mailing list tomcat-dev@jakarta.apache.org
Received: (qmail 36663 invoked by uid 99); 5 Oct 2004 00:25:45 -0000
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received-SPF: pass (hermes.apache.org: local policy)
Received: from [192.18.98.34] (HELO brmea-mail-3.sun.com) (192.18.98.34)
  by apache.org (qpsmtpd/0.28) with ESMTP; Mon, 04 Oct 2004 17:25:43 -0700
Received: from phys-d3-ha21sca-1 ([129.145.155.163])
	by brmea-mail-3.sun.com (8.12.10/8.12.9) with ESMTP id i950Pgil012742
	for <tomcat-dev@jakarta.apache.org>; Mon, 4 Oct 2004 18:25:42 -0600 (MDT)
Received: from conversion-daemon.ha21sca-mail1.sfbay.sun.com by
 ha21sca-mail1.sfbay.sun.com
 (iPlanet Messaging Server 5.2 HotFix 1.24 (built Dec 19 2003))
 id <0I530040155QPY@ha21sca-mail1.sfbay.sun.com>
 (original mail from Jan.Luehe@Sun.COM) for tomcat-dev@jakarta.apache.org;
 Mon,
 04 Oct 2004 17:25:42 -0700 (PDT)
Received: from sun.com (raga2.SFBay.Sun.COM [129.145.132.30])
 by ha21sca-mail1.sfbay.sun.com
 (iPlanet Messaging Server 5.2 HotFix 1.24 (built Dec 19 2003))
 with ESMTP id <0I5300I2N56TWG@ha21sca-mail1.sfbay.sun.com> for
 tomcat-dev@jakarta.apache.org; Mon, 04 Oct 2004 17:25:41 -0700 (PDT)
Date: Mon, 04 Oct 2004 17:25:41 -0700
From: Jan Luehe <Jan.Luehe@Sun.COM>
Subject: Re: cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml
 jasper-howto.xml
In-reply-to: <4161C9C2.6010508@apache.org>
To: Tomcat Developers List <tomcat-dev@jakarta.apache.org>
Reply-to: Jan.Luehe@Sun.COM
Message-id: <4161EA05.20605@sun.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii; format=flowed
Content-transfer-encoding: 7BIT
X-Accept-Language: en-US
User-Agent: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.4) Gecko/20040414
References: <20041004173946.74365.qmail@minotaur.apache.org>
 <41618E45.7040609@sun.com> <4161B5B1.4090604@apache.org>
 <4161C6A9.9060200@sun.com> <4161C9C2.6010508@apache.org>
X-Virus-Checked: Checked
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N


> I feel strongly about this. Dev mode is the default, and is needed for 
> some special purpose stuff (where JSPs are regenerated on the fly), so 
> it need to perform relatively well.
> 
> IMO, the background reloading thread is way too complex and buggy. It 
> should go in favor of a much simpler mechanism (if you really want only 
> one thing; personally, I would keep both, as it's more flexible).
> 
>>
>>   +<li><strong>modificationTestInterval</strong> - If development has 
>> to be set to
>>   +<code>true</code> for any reason (such as dynamic generation of 
>> JSPs), setting
>>   +this to a high value will improve performance a lot.</li>
>>
>> Why won't dynamic generation of JSPs work in nondev mode? Notice that
>> in JspServleWrapper, we compile if
>>
>>   options.getDevelopment() || firstTime
> 
> 
> It works for the first compilation, of course. But most people who use 
> that obvious refresh their JSPs.
> 
> Overall, I think that having two attributes is appropriate.

OK, I think I've bought your point.

Can we specify the interval in seconds then, or what was the reason
to specify it in ms? Do you think a JSP could change that frequently?
When you specify a value <1000ms, you might as well specify -1.

Also, we should add this option to the documentation of the
JspServlet init params in the default web.xml.


Jan


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org