Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
Received-SPF: pass (hermes.apache.org: local policy)
Message-ID: <01f101c4bae5$e3a7ab30$6c37a8c0@bbarkerxp>
From: "Bill Barker" <wbarker@wilshire.com>
To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
References: <20041025211849.84682.qmail@minotaur.apache.org>
Subject: Re: cvs commit:
 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/security
 SecurityUtil.java
Date: Mon, 25 Oct 2004 15:56:40 -0700
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----------=_1098744976-8741-50"

------------=_1098744976-8741-50
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


----- Original Message -----
From: <luehe@apache.org>
To: <jakarta-tomcat-catalina-cvs@apache.org>
Sent: Monday, October 25, 2004 2:18 PM
Subject: cvs commit:
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/security
SecurityUtil.java


>   @@ -251,18 +251,17 @@
>                    if (session != null){
>                        subject =
>
(Subject)session.getAttribute(Globals.SUBJECT_ATTR);
>   -                }
>
>   -                if (subject == null){
>   -                    subject = new Subject();
>   +                    if (subject == null){
>   +                        subject = new Subject();
>
>   -                    if (principal != null){
>   -                        subject.getPrincipals().add(principal);
>   +                        if (principal != null){
>   +                            subject.getPrincipals().add(principal);
>   +                        }
>   +
>   +                        session.setAttribute(Globals.SUBJECT_ATTR,
subject);
>                        }
>                    }
>   -
>   -                if (session != null)
>   -                    session.setAttribute(Globals.SUBJECT_ATTR,
subject);
>                }
>
>                Subject.doAsPrivileged(subject, pea, null);

With this patch, If there is no session defined, then 'subject' will be null
when I get to the doAsPrivieged.


This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL.  If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail.


------------=_1098744976-8741-50
Content-Type: text/plain; charset=us-ascii

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
------------=_1098744976-8741-50--