tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Barker" <wbar...@wilshire.com>
Subject Re: cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml
Date Mon, 04 Oct 2004 23:07:20 GMT

----- Original Message -----
From: "Amy Roh" <amyroh@apache.org>
To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
Sent: Monday, October 04, 2004 3:30 PM
Subject: Re: cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml


> Hi Remy,
>
> >  Modified:    .        build.xml
> >               catalina/src/share/org/apache/catalina/core
> >                        StandardContext.java StandardEngine.java
> >                        mbeans-descriptors.xml
> >               catalina/src/share/org/apache/catalina/connector
> >                        Connector.java
> >               resources/mbeans tomcat5-ant.xml
> >               catalina/src/share/org/apache/catalina/realm
RealmBase.java
> >               webapps/docs changelog.xml
> >  Log:
> >  - Fix embed and deployer packaging.
> >  - Fix JMX registration of realm.
> >  - Fix a variety of problems in MBean names.
>
> >  1.26      +18 -1
> >
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/Standard
Engine.java
> >
> >  Index: StandardEngine.java
> >  ===================================================================
> >  RCS file:
> >
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/cor
e/StandardEngine.java,v
> >  retrieving revision 1.25
> >  retrieving revision 1.26
> >  diff -u -r1.25 -r1.26
> >  --- StandardEngine.java 16 Aug 2004 09:31:05 -0000 1.25
> >  +++ StandardEngine.java 3 Oct 2004 08:53:56 -0000 1.26
> >  @@ -404,6 +404,23 @@
> >           if( !initialized ) {
> >               init();
> >           }
> >  +
> >  +        // Look for a realm - that may have been configured earlier.
> >  +        // If the realm is added after context - it'll set itself.
> >  +        if( realm == null ) {
> >  +            ObjectName realmName=null;
> >  +            try {
> >  +                realmName=new ObjectName( domain + ":type=Realm");
> >  +                if( mserver.isRegistered(realmName ) ) {
> >  +                    Realm nrealm =
> > (Realm)mserver.getAttribute(realmName,
> >  +
> > "managedResource");
>
> I don't think Realm has "managedResource" attribute.
>

It was on Peter's wish-list to add "managedResource" to the Realms.  This
was taken from (I think :) StandardHost, where the code was so broken that
it was impossible that anybody was using it, so waiting for
"managedResource" to be added to the mbean-descriptor was reasonable.

> Shouldn't we be moving towards getting rid of all non-serializable
> attributes and return types in order to support remote access to
MBeanServer
> using JSR 160?
>

Except that "managedResource" is an internal-implementation artifact of c-m.
There really isn't any point in getting rid of it before Remy's project to
make c-m an optional component.


> Thanks,
> Amy
>



Mime
View raw message