Return-Path: Delivered-To: apmail-jakarta-tomcat-dev-archive@www.apache.org Received: (qmail 2134 invoked from network); 1 Oct 2004 03:14:47 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 1 Oct 2004 03:14:47 -0000 Received: (qmail 55132 invoked by uid 500); 1 Oct 2004 03:14:24 -0000 Delivered-To: apmail-jakarta-tomcat-dev-archive@jakarta.apache.org Received: (qmail 55020 invoked by uid 500); 1 Oct 2004 03:14:23 -0000 Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Tomcat Developers List" Reply-To: "Tomcat Developers List" Delivered-To: mailing list tomcat-dev@jakarta.apache.org Received: (qmail 55006 invoked by uid 99); 1 Oct 2004 03:14:23 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (hermes.apache.org: local policy) Received: from [192.18.98.36] (HELO brmea-mail-4.sun.com) (192.18.98.36) by apache.org (qpsmtpd/0.28) with ESMTP; Thu, 30 Sep 2004 20:14:22 -0700 Received: from phys-d3-ha21sca-1 ([129.145.155.163]) by brmea-mail-4.sun.com (8.12.10/8.12.9) with ESMTP id i913EL53017770 for ; Thu, 30 Sep 2004 21:14:21 -0600 (MDT) Received: from conversion-daemon.ha21sca-mail1.sfbay.sun.com by ha21sca-mail1.sfbay.sun.com (iPlanet Messaging Server 5.2 HotFix 1.24 (built Dec 19 2003)) id <0I4V00801Y2P2K@ha21sca-mail1.sfbay.sun.com> (original mail from jfarcand@apache.org) for tomcat-dev@jakarta.apache.org; Thu, 30 Sep 2004 20:14:20 -0700 (PDT) Received: from [192.168.2.37] (vpn-129-152-224-169.East.Sun.COM [129.152.224.169]) by ha21sca-mail1.sfbay.sun.com (iPlanet Messaging Server 5.2 HotFix 1.24 (built Dec 19 2003)) with ESMTP id <0I4V00CA1YBW8K@ha21sca-mail1.sfbay.sun.com> for tomcat-dev@jakarta.apache.org; Thu, 30 Sep 2004 20:14:20 -0700 (PDT) Date: Thu, 30 Sep 2004 23:14:53 -0400 From: Jean-Francois Arcand Subject: Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationContextFacade.java ApplicationFilterChain.java StandardWrapper.java In-reply-to: <415C7655.3090706@apache.org> To: Tomcat Developers List Message-id: <415CCBAD.2020709@apache.org> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 8BIT X-Accept-Language: en-us, en User-Agent: Mozilla Thunderbird 0.8 (X11/20040913) References: <20040930152621.18569.qmail@minotaur.apache.org> <007a01c4a71c$189fdf70$6c37a8c0@bbarkerxp> <415C6253.8060700@apache.org> <415C7655.3090706@apache.org> X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Remy Maucherat wrote: > Jean-Francois Arcand wrote: > >> Bill Barker wrote: >> >>> This can't possibly be thread-safe (and the changes to ACF look >>> dubious as >>> well). >> >> >> Hum...I did run a lot of stress tests that target the same servlet >> (ex: trade2 benchmarks) without seeing anything like that. I will >> investigate.... > > > I think there will be thread safety problems too. There's no way around > instantiating argument arrays here. I agree. I've reverted the patch. The only solution will be to "nulllify" all objects after every calls. > I also think the shared classCache is not useful. I don't see why > objectCache couldn't be static, so it could be the only cache. OK will take a look. Thanks -- Jeanfrancois > > R�my > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org > For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org