Return-Path: Delivered-To: apmail-jakarta-tomcat-dev-archive@www.apache.org Received: (qmail 35746 invoked from network); 13 Sep 2004 18:22:47 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 13 Sep 2004 18:22:47 -0000 Received: (qmail 28989 invoked by uid 500); 13 Sep 2004 18:22:38 -0000 Delivered-To: apmail-jakarta-tomcat-dev-archive@jakarta.apache.org Received: (qmail 28766 invoked by uid 500); 13 Sep 2004 18:22:36 -0000 Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Tomcat Developers List" Reply-To: "Tomcat Developers List" Delivered-To: mailing list tomcat-dev@jakarta.apache.org Received: (qmail 28753 invoked by uid 99); 13 Sep 2004 18:22:36 -0000 X-ASF-Spam-Status: No, hits=-2.8 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [209.237.227.194] (HELO minotaur.apache.org) (209.237.227.194) by apache.org (qpsmtpd/0.28) with SMTP; Mon, 13 Sep 2004 11:22:36 -0700 Received: (qmail 35654 invoked from network); 13 Sep 2004 18:22:34 -0000 Received: from localhost.hyperreal.org (HELO ?127.0.0.1?) (127.0.0.1) by localhost.hyperreal.org with SMTP; 13 Sep 2004 18:22:34 -0000 Message-ID: <4145E569.2050109@apache.org> Date: Mon, 13 Sep 2004 20:22:33 +0200 From: Remy Maucherat User-Agent: Mozilla Thunderbird 0.7.3 (Windows/20040803) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java References: <20040823192935.39573.qmail@minotaur.apache.org> In-Reply-To: <20040823192935.39573.qmail@minotaur.apache.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Rating: localhost.hyperreal.org 1.6.2 0/1000/N X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N markt@apache.org wrote: >markt 2004/08/23 12:29:35 > > Modified: http11/src/java/org/apache/coyote/http11 > Http11Processor.java > Log: > Fix bug 16254 - Server header appears twice after a call to response.setHeader() > > Revision Changes Path > 1.105 +3 -1 jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Processor.java > > Index: Http11Processor.java > =================================================================== > RCS file: /home/cvs/jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Processor.java,v > retrieving revision 1.104 > retrieving revision 1.105 > diff -u -r1.104 -r1.105 > --- Http11Processor.java 21 Aug 2004 02:51:37 -0000 1.104 > +++ Http11Processor.java 23 Aug 2004 19:29:35 -0000 1.105 > @@ -1511,7 +1511,9 @@ > } > > // Add server header > - response.addHeader("Server", Constants.SERVER); > + if (! response.containsHeader("Server")){ > + response.addHeader("Server", Constants.SERVER); > + } > > As I said way back then, I dislike this patch. I will now revert it (as Scott pointed out, the X-Powered-By header is used for that kind of purpose). R�my --------------------------------------------------------------------- To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org