Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
Received-SPF: neutral (hermes.apache.org: local policy)
Date: Mon, 20 Sep 2004 11:16:37 -0700
From: Amy Roh <amyroh@apache.org>
Subject: Re: cvs commit:
 jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler
 SmapUtil.java
To: Tomcat Developers List <tomcat-dev@jakarta.apache.org>
Message-id: <017901c49f3d$f85a5eb0$5c1a9681@AMYROH>
MIME-version: 1.0
Content-type: text/plain; format=flowed; charset=iso-8859-1;
 reply-type=response
Content-transfer-encoding: 7BIT
References: <20040920175128.20622.qmail@minotaur.apache.org>
 <414F19ED.3060403@apache.org> <013401c49f3c$8b2294d0$5c1a9681@AMYROH>
 <414F1F9C.8020907@progeeks.com>


>
> Amy Roh wrote:
>
>>> amyroh@apache.org wrote:
>>>
>>>> amyroh      2004/09/20 10:51:28
>>>>
>>>>  Modified:    jasper2/src/share/org/apache/jasper/compiler 
>>>> SmapUtil.java
>>>>  Log:
>>>>  Remove verbose.
>>>>  -            if (verbose) {
>>>>  -                if (log.isDebugEnabled())
>>>>  -                    log.debug("constant pool count: " + 
>>>> constantPoolCount);
>>>>  -            }
>>>>  +            log("constant pool count: " + constantPoolCount);
>>>>
>>> You need to keep if (log.isDebugEnabled()), otherwise, zillions of 
>>> Strings will be created for no reason (as the parameter of your method 
>>> will have to be created).
>>
>>
>> I have added the following log helper method so I don't have to do if 
>> (log.isDebugEnabled()) everytime I use log.debug()
>>
>>  +
>>  +    private static void log(String msg) {
>>  +        if (log.isDebugEnabled())
>>  +            log.debug(msg);
>>  +    }
>>  +
>>   }
>>
>> Amy
>
> >>>  +            log("constant pool count: " + constantPoolCount);
>
> But even to call your log() method, a String will need to be created that 
> combines the "constant pool count:" with a 
> String.valueOf(constantPoolCount).  Even if it's just going to be thrown 
> away.
> -Paul

Ah, I see what you mean.  I'll commit the fix. 


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org