Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
Received-SPF: pass (hermes.apache.org: local policy)
Message-ID: <007a01c4a71c$189fdf70$6c37a8c0@bbarkerxp>
From: "Bill Barker" <wbarker@wilshire.com>
To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
References: <20040930152621.18569.qmail@minotaur.apache.org>
Subject: Re: cvs commit:
 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core
 ApplicationContextFacade.java ApplicationFilterChain.java
 StandardWrapper.java
Date: Thu, 30 Sep 2004 11:34:18 -0700
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----------=_1096569225-28012-111"

------------=_1096569225-28012-111
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

>   @@ -1012,13 +1041,12 @@
>                        DummyResponse res = new DummyResponse();
>
>                        if( System.getSecurityManager() != null) {
>   -                        Class[] classType = new
Class[]{ServletRequest.class,
>   -
ServletResponse.class};
>   -                        Object[] args = new Object[]{req, res};
>   +                        serviceType[0] = req;
>   +                        serviceType[1] = res;
>                            SecurityUtil.doAsPrivilege("service",
>                                                       servlet,
>   -                                                   classType,
>   -                                                   args);
>   +
classTypeUsedInService,
>   +                                                   serviceType);
>                        } else {
>                            servlet.service(req, res);
>                        }
>
>

This can't possibly be thread-safe (and the changes to ACF look dubious as
well).


------------=_1096569225-28012-111
Content-Type: text/plain; name="disclaimer.txt"
Content-Disposition: inline; filename="disclaimer.txt"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-Mailer: MIME-tools 5.411 (Entity 5.404)


This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL.  If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail.


------------=_1096569225-28012-111
Content-Type: text/plain; charset=us-ascii

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
------------=_1096569225-28012-111--