tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Remy Maucherat <r...@apache.org>
Subject Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java
Date Mon, 13 Sep 2004 18:22:33 GMT
markt@apache.org wrote:

>markt       2004/08/23 12:29:35
>
>  Modified:    http11/src/java/org/apache/coyote/http11
>                        Http11Processor.java
>  Log:
>  Fix bug 16254 - Server header appears twice after a call to response.setHeader()
>  
>  Revision  Changes    Path
>  1.105     +3 -1      jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Processor.java
>  
>  Index: Http11Processor.java
>  ===================================================================
>  RCS file: /home/cvs/jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Processor.java,v
>  retrieving revision 1.104
>  retrieving revision 1.105
>  diff -u -r1.104 -r1.105
>  --- Http11Processor.java	21 Aug 2004 02:51:37 -0000	1.104
>  +++ Http11Processor.java	23 Aug 2004 19:29:35 -0000	1.105
>  @@ -1511,7 +1511,9 @@
>           }
>            
>           // Add server header
>  -        response.addHeader("Server", Constants.SERVER);
>  +        if (! response.containsHeader("Server")){
>  +            response.addHeader("Server", Constants.SERVER);
>  +        }
>  
>
As I said way back then, I dislike this patch. I will now revert it (as 
Scott pointed out, the X-Powered-By header is used for that kind of 
purpose).

Rémy


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message