tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Barker" <wbar...@wilshire.com>
Subject Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationContextFacade.java ApplicationFilterChain.java StandardWrapper.java
Date Thu, 30 Sep 2004 18:34:18 GMT
>   @@ -1012,13 +1041,12 @@
>                        DummyResponse res = new DummyResponse();
>
>                        if( System.getSecurityManager() != null) {
>   -                        Class[] classType = new
Class[]{ServletRequest.class,
>   -
ServletResponse.class};
>   -                        Object[] args = new Object[]{req, res};
>   +                        serviceType[0] = req;
>   +                        serviceType[1] = res;
>                            SecurityUtil.doAsPrivilege("service",
>                                                       servlet,
>   -                                                   classType,
>   -                                                   args);
>   +
classTypeUsedInService,
>   +                                                   serviceType);
>                        } else {
>                            servlet.service(req, res);
>                        }
>
>

This can't possibly be thread-safe (and the changes to ACF look dubious as
well).


Mime
View raw message