tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeanfrancois Arcand <jfarc...@apache.org>
Subject Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper Mapper.java
Date Wed, 25 Aug 2004 21:40:19 GMT


Remy Maucherat wrote:

> Jeanfrancois Arcand wrote:
>
>>
>>
>> Remy Maucherat wrote:
>>
>>> jfarcand@apache.org wrote:
>>>
>>>> jfarcand    2004/08/25 12:25:46
>>>>
>>>>  Modified:    util/java/org/apache/tomcat/util/http/mapper Mapper.java
>>>>  Log:
>>>>  Add missing case to support the following web.xml:
>>>>  
>>>>      <servlet>
>>>>          <display-name>ServletTest</display-name>
>>>>          <servlet-name>ServletTest</servlet-name>
>>>>          <servlet-class>test.ServletTest</servlet-class>
>>>>      </servlet>
>>>>      <servlet-mapping>
>>>>          <servlet-name>ServletTest</servlet-name>
>>>>          <url-pattern>*.screen</url-pattern>
>>>>      </servlet-mapping>
>>>>      <welcome-file-list>
>>>>         <welcome-file>welcome.screen</welcome-file>
>>>>      </welcome-file-list>
>>>>  
>>>>  All Servlet TCKs passed. Please review (I recall some discussion 
>>>> on welcome file but can't find those emails).
>>>>  
>>>>
>>> -1, this was on purpose. Extension mapping in welcome files cannot 
>>> work.
>>> Since you have no way of testing if the resource exists or not, the 
>>> request will *always* be redirected to the welcome file. It also 
>>> means that, with the default settings and mappings, all requests to 
>>> a folder will end up being redirected to index.jsp. I thought this 
>>> was obvious enough.
>>
>>
>>
>> Not enough for me ;-). So if it's impossible, the spec should be 
>> updated, righ?
>
>
> Sorry, I'm almost certain I had talked about it earlier: that's the 
> reason for my comment.
> I really don't see any way to implement it (if you find one ...), so 
> IMO the spec is broken for extension mapping with welcome files (since 
> they'll always match *.jsp with index.jsp - ok, I know, it's a static 
> file, so there's a way to check in the special case).

OK I will investigate more.

> For exact or wildcard mappings, there's no problem.
>
> If you want more spec issues, let me know :)
> (right now, I have session handling with cross context, and also 
> request dispatching and wrapping)

Actually, yes, raise them :-)  This is the perfect time for raising 
issues to the spec leads if we want a fix for the next spec revision. 
This mapping issue was sent by the spec leads, so probably somebody else 
complained about that.

Thanks

-- Jeanfrancois

>
> Rémy
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message