tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mladen Turk" <mt...@apache.org>
Subject RE: cvs commit: jakarta-tomcat-connectors/ajp/proxy mod_proxy.c
Date Wed, 04 Aug 2004 16:35:50 GMT
I'm experiencing cca 2 hour mail delay on minotaur.
Can you cc: to mladen.turk@gisdata,hr

jean-frederic clere wrote: 
> [mailto:jfrederic.clere@fujitsu-siemens.com] 
> Sent: Wednesday, August 04, 2004 3:20 PM
> To: Tomcat Developers List
> Subject: Re: cvs commit: jakarta-tomcat-connectors/ajp/proxy 
> mod_proxy.c
> 
> Mladen Turk wrote:
> >  
> > 
> > jfclere@apache.org commited:
> > 
> >>   
> >>       new = apr_array_push(conf->aliases);
> >>  -    new->fake = f;
> >>  -    new->real = r;
> >>  +    new->fake = apr_pstrdup(cmd->pool, f);
> >>  +    new->real = apr_pstrdup(cmd->pool, r);
> >>       
> >>
> > 
> > 
> > There is no need to do that.
> > The f is eventually set to cmd->path that is already duped 
> from cmd pool.
> > They r is always obtained using ap_getword_conf.
> 
> Without the apr_pstrdup() it does not work on my machine...
> I have seen that real gets corrupted. (fake does not but in 
> my test it set to cmd-path).
> 

Well, then there is some other bug (I'll check).
The real is always obtained using ap_getword_conf that internally makes
apr_palloc for the return value.
Further more the same (cmd->pool) pool is used for them, so it should fail
on apr_pstrdup(cmd->pool, r).


MT.

Mime
View raw message