tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Tribble" <jtrib...@mikart.com>
Subject RE: cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml
Date Mon, 30 Aug 2004 11:54:29 GMT
UNSUBSCRIBE !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

Joe R. Tribble
Manager IT Operations
 
Mikart, Inc.
1750 Chattachoochee Avenue
Atlanta, Ga 30318
404-351-4510  x124
jtribble@mikart.com
 

-----Original Message-----
From: Remy Maucherat [mailto:remm@apache.org] 
Sent: Saturday, August 28, 2004 9:49 AM
To: Tomcat Developers List
Subject: Re: cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

yoavs@apache.org wrote:

>yoavs       2004/08/28 05:49:55
>
>  Modified:    catalina/src/share/org/apache/catalina/core Tag: TOMCAT_5_0
>                        StandardContext.java
>               webapps/docs Tag: TOMCAT_5_0 changelog.xml
>  Log:
>  Addressed Bugzilla 30762.  Risky fix I think, but better than the current broken behavior.
>  
>  Revision  Changes    Path
>  No                   revision
>  No                   revision
>  1.130.2.1 +9 -2      jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java
>  
>  Index: StandardContext.java
>  ===================================================================
>  RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java,v
>  retrieving revision 1.130
>  retrieving revision 1.130.2.1
>  diff -u -r1.130 -r1.130.2.1
>  --- StandardContext.java	7 Jun 2004 15:30:06 -0000	1.130
>  +++ StandardContext.java	28 Aug 2004 12:49:54 -0000	1.130.2.1
>  @@ -4497,7 +4497,11 @@
>           }
>   
>           // Stop our application listeners
>  -        listenerStop();
>  +        // I think this should be after the children are stopped,
>  +        // because now servlet destroy() is called AFTER 
>  +        // contextDestroyed, which is a Spec violation as noted
>  +        // Bugzilla 30762.
>  +        // listenerStop();
>   
>           // Finalize our character set mapper
>           setCharsetMapper(null);
>  @@ -4538,6 +4542,9 @@
>               if ((loader != null) && (loader instanceof Lifecycle)) {
>                   ((Lifecycle) loader).stop();
>               }
>  +
>  +            // Now stop the listeners, Bugzilla 30762
>  +            listenerStop();
>   
>
You should stop them at least before the loader, or there will be trouble.

Rémy

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message