Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
Message-ID: <40F3B7C0.5040106@apache.org>
Date: Tue, 13 Jul 2004 12:21:52 +0200
From: Henri Gomez <hgomez@apache.org>
User-Agent: Mozilla Thunderbird 0.7.1 (Windows/20040626)
MIME-Version: 1.0
To: Tomcat Developers List <tomcat-dev@jakarta.apache.org>
Subject: Re: jk_connect and multi-threading
References: <40ED75C0.8090802@fujitsu-siemens.com>
 <PoiemLlEfY7y8nQjYiqVliTObbsEYgc14FW12gv6nWa@akmail>
 <40EEBF6E.4050904@fujitsu-siemens.com>
 <vTT51zDMUH3KFr29Z69nYpYFiFyE5Q5xCYHKwUQ6qbz@akmail>
 <40F262F2.8070809@apache.org> <004f01c4683c$b0a53500$6c37a8c0@bbarkerxp>
 <40F37D60.2040104@apache.org> <40F38266.1080704@apache.org>
 <40F38A5C.7010908@fujitsu-siemens.com>
In-Reply-To: <40F38A5C.7010908@fujitsu-siemens.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

jean-frederic clere wrote:
> Henri Gomez wrote:
> 
>> Henri Gomez wrote:
>>
>>> Bill Barker wrote:
>>>
>>>> ----- Original Message -----
>>>> From: "Henri Gomez" <hgomez@apache.org>
>>>> To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
>>>> Sent: Monday, July 12, 2004 3:07 AM
>>>> Subject: jk_connect and multi-threading
>>>>
>>>>
>>>>
>>>>> Hi to all,
>>>>>
>>>>> I'm looking for a strange problem under iSeries (AS/400) and wonder
>>>>> about this look in jk_open_socket() (jk_connect.c) :
>>>>>
>>>>>         do {
>>>>>             jk_log(l, JK_LOG_DEBUG, "jk_open_socket, try to connect
>>>>> socket = %d to %s\n",
>>>>>                    sock, jk_dump_hinfo(addr, buf));
>>>>>
>>>>>             ret = connect(sock,
>>>>>                           (struct sockaddr *)addr,
>>>>>                           sizeof(struct sockaddr_in));
>>>>> #if defined(WIN32) || (defined(NETWARE) && defined(__NOVELL_LIBC__))
>>>>>             if(SOCKET_ERROR == ret) {
>>>>>                 errno = WSAGetLastError() - WSABASEERR;
>>>>>             }
>>>>> #endif /* WIN32 */
>>>>>             jk_log(l, JK_LOG_DEBUG, "jk_open_socket, after connect ret
>>>>> = %d\n", ret);
>>>>>         } while (-1 == ret && EINTR == errno);
>>>>>
>>>>>
>>>>> What's the status on errno in multi-threaded environnement ?
>>>>>
>>>>
>>>>
>>>> On older *nix boxes it wasn't safe to use it with threads.  Don't 
>>>> know about
>>>> iSeries.  On Solaris it's per-thread (assuming that you've compiled
>>>> with -D_REENTRANT).
>>>>
>>>>
>>>>> Shouldn't we clear errno before the connect() call ?
>>>>>
>>>>
>>>>
>>>> It's not supposed to matter.
>>>>
>>>>
>>>>> BTW, I wonder why we check the errno in such case...
>>>
>>>
>>>
>>>
>>> Ok, I take a look at IBM errno list and error 3021 is for EINVAL 
>>> (invalid argument).
>>>
>>> I'll investigate this error farther...
>>
>>
>>
>> The problem could be related to BSD 4.4/Unix 98 where the sa_len 
>> should be defined before connect call. May be one of the various 
>> reason where
>> jk_connect failed strangely on many boxes.
> 
> 
> Yes, APR uses:
> +++
> apr_status_t apr_socket_connect(apr_socket_t *sock, apr_sockaddr_t *sa)
> {
>     int rc;
> 
>     do {
>         rc = connect(sock->socketdes,
>                      (const struct sockaddr *)&sa->sa.sin,
>                      sa->salen);
>     } while (rc == -1 && errno == EINTR);
> +++
> So setting  sa_len and USING sa_len instead sizeof(sockaddr_in) in the 
> socket() should fix most of the problems.

Ok, but how could we get the correct sa_len ?

Patch welcome


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org