Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
Message-ID: <011901c475a7$cec14f60$6c37a8c0@bbarkerxp>
From: "Bill Barker" <wbarker@wilshire.com>
To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
References: <20040729191943.1882.qmail@minotaur.apache.org>
Subject: Re: cvs commit:
 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/mbeans
 MBeanUtils.java
Date: Thu, 29 Jul 2004 13:08:26 -0700
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----------=_1091131673-17738-180"

------------=_1091131673-17738-180
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


----- Original Message -----
From: <markt@apache.org>
To: <jakarta-tomcat-catalina-cvs@apache.org>
Sent: Thursday, July 29, 2004 12:19 PM
Subject: cvs commit:
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/mbeans
MBeanUtils.java


> markt       2004/07/29 12:19:43
>
>   Modified:    catalina/src/share/org/apache/catalina/mbeans
>                         MBeanUtils.java
>   Log:
>   Fix bug 28178. Quote user and group names to handle situation with
>   certs where names may conain '='.
>   As far as I can tell, this doesn't break the admin app for users but I
will
>   need to do some more testing once the 5.5 changes are completed.
>
>   Revision  Changes    Path
>   1.29      +5 -5
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/mbeans/MBeanU
tils.java
>
>   Index: MBeanUtils.java
>   ===================================================================
>   RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/mbe
ans/MBeanUtils.java,v
>   retrieving revision 1.28
>   retrieving revision 1.29
>   diff -u -r1.28 -r1.29
>   --- MBeanUtils.java 13 Jul 2004 09:38:21 -0000 1.28
>   +++ MBeanUtils.java 29 Jul 2004 19:19:43 -0000 1.29
>   @@ -1068,8 +1068,8 @@
>
>            ObjectName name = null;
>            name = new ObjectName(domain + ":type=Group,groupname=" +
>   -                              group.getGroupname() + ",database=" +
>   -                              group.getUserDatabase().getId());
>   +                              ObjectName.quote(group.getGroupname()) +
>   +                              ",database=" +
group.getUserDatabase().getId());
>            return (name);
>
>        }
>   @@ -1396,8 +1396,8 @@
>
>            ObjectName name = null;
>            name = new ObjectName(domain + ":type=User,username=" +
>   -                              user.getUsername() + ",database=" +
>   -                              user.getUserDatabase().getId());
>   +                              ObjectName.quote(user.getUsername())
>   +                              + ",database=" +
user.getUserDatabase().getId());
>            return (name);
>
>        }
>

The rest of the code is using MBeanUtils.encodeStr() for this.  For
consistancy, you might want to use change that to do ON.quote, or use
encodeStr here.


>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>


------------=_1091131673-17738-180
Content-Type: text/plain; name="disclaimer.txt"
Content-Disposition: inline; filename="disclaimer.txt"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-Mailer: MIME-tools 5.411 (Entity 5.404)


This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL.  If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail.


------------=_1091131673-17738-180
Content-Type: text/plain; charset=us-ascii

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
------------=_1091131673-17738-180--