tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 28631] - JAASRealm fix to permit user-specified user/group Principals
Date Thu, 29 Jul 2004 13:43:56 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=28631>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28631

JAASRealm fix to permit user-specified user/group Principals





------- Additional Comments From yoavs@computer.org  2004-07-29 13:43 -------
Typical test cases submitted for Tomcat are WAR files.  They contain the code 
to be tested along with the META-INF/context.xml file which is the Context 
element with the proper declarations, e.g. for a Realm.  Don't bother using the 
Tester approach, that's wasted effort on build files.

For this case a dummy LoginModule with hard-coded user names and passwords is 
fine.  Also for this case, since the Realm has to be in a common classloader 
repository, a single WAR won't be possible, so maybe a separate JAR.

Basically, we ask for whatever you would use to unit-test your own patch.  I 
understand it works for you, and that's great, and if you don't unit-test 
that's also OK (I sometimes don't do it either, we're not perfect ;)).  But we 
do prefer to have unit tests before committing into the core Tomcat code.

I also wanted to assess your interest in this: I'm glad you responded, and 
quickly.  If I ask for tests, give it a couple of months with no response, then 
ask again and get no response within a month or so, I sometimes close the 
bugzilla issue for lack of interest.  Because you responded we can keep this 
open and resolve it.

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message