tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 29938] New: - cygwin cygpath usage to convert to windows dirs
Date Tue, 06 Jul 2004 18:31:00 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=29938>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=29938

cygwin cygpath usage to convert to windows dirs

           Summary: cygwin cygpath usage to convert to windows dirs
           Product: Tomcat 5
           Version: 5.0.25
          Platform: PC
        OS/Version: Other
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: Catalina
        AssignedTo: tomcat-dev@jakarta.apache.org
        ReportedBy: amoebaworks@yahoo.ca


1) JAVA_HOME, CATALINA_HOME, CATALINA_BASE, CATALINA_TMPDIR are not path 
variables (ie: bin\java:/usr/local/java) but are directories (the other type of 
paths :-). When the conversion is made back to windows dirs, the cygpath 
commands have the '--path' option included, which shouldn't be there. See 
cygpath help for more info on paths & dirs.

So need a fix so that no '--path' option should be set for JAVA_HOME, 
CATALINA_HOME, CATALINA_BASE, CATALINA_TMPDIR.

2) Also I sometimes use CATALINA_BASE of '.' cygpath converts this to '.\' 
with 'cygpath --windows .' (why I don't know) but this later causes 
the 'touch "$CATALINA_BASE"/logs/catalina.out' on line 203 to fail because the 
converted path is: '.\/logs/catalina.out'. If the cygpath option '--absolute' 
is added it prevents this case from happening.

So need another fix for CATALINA_BASE to have the '--absolute' option added. 

Actually it can be added to JAVA_HOME, CATALINA_HOME, and CATALINA_TMPDIR too 
without problems but usually these don't have '.' as their dirpath. It probably 
should be added for these too for consistency.

------------------------------------------------
Here's the diff for the patch:
catalina.sh (rev 1.14) 
117,120c117,120
<   JAVA_HOME=`cygpath --path --windows "$JAVA_HOME"`
<   CATALINA_HOME=`cygpath --path --windows "$CATALINA_HOME"`
<   CATALINA_BASE=`cygpath --path --windows "$CATALINA_BASE"`
<   CATALINA_TMPDIR=`cygpath --path --windows "$CATALINA_TMPDIR"`
---
>   JAVA_HOME=`cygpath --windows --absolute "$JAVA_HOME"`
>   CATALINA_HOME=`cygpath --windows --absolute "$CATALINA_HOME"`
>   CATALINA_BASE=`cygpath --windows --absolute "$CATALINA_BASE"`
>   CATALINA_TMPDIR=`cygpath --windows --absolute "$CATALINA_TMPDIR"`

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message