tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Barker" <wbar...@wilshire.com>
Subject Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/mbeans MBeanUtils.java
Date Thu, 29 Jul 2004 20:08:26 GMT

----- Original Message -----
From: <markt@apache.org>
To: <jakarta-tomcat-catalina-cvs@apache.org>
Sent: Thursday, July 29, 2004 12:19 PM
Subject: cvs commit:
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/mbeans
MBeanUtils.java


> markt       2004/07/29 12:19:43
>
>   Modified:    catalina/src/share/org/apache/catalina/mbeans
>                         MBeanUtils.java
>   Log:
>   Fix bug 28178. Quote user and group names to handle situation with
>   certs where names may conain '='.
>   As far as I can tell, this doesn't break the admin app for users but I
will
>   need to do some more testing once the 5.5 changes are completed.
>
>   Revision  Changes    Path
>   1.29      +5 -5
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/mbeans/MBeanU
tils.java
>
>   Index: MBeanUtils.java
>   ===================================================================
>   RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/mbe
ans/MBeanUtils.java,v
>   retrieving revision 1.28
>   retrieving revision 1.29
>   diff -u -r1.28 -r1.29
>   --- MBeanUtils.java 13 Jul 2004 09:38:21 -0000 1.28
>   +++ MBeanUtils.java 29 Jul 2004 19:19:43 -0000 1.29
>   @@ -1068,8 +1068,8 @@
>
>            ObjectName name = null;
>            name = new ObjectName(domain + ":type=Group,groupname=" +
>   -                              group.getGroupname() + ",database=" +
>   -                              group.getUserDatabase().getId());
>   +                              ObjectName.quote(group.getGroupname()) +
>   +                              ",database=" +
group.getUserDatabase().getId());
>            return (name);
>
>        }
>   @@ -1396,8 +1396,8 @@
>
>            ObjectName name = null;
>            name = new ObjectName(domain + ":type=User,username=" +
>   -                              user.getUsername() + ",database=" +
>   -                              user.getUserDatabase().getId());
>   +                              ObjectName.quote(user.getUsername())
>   +                              + ",database=" +
user.getUserDatabase().getId());
>            return (name);
>
>        }
>

The rest of the code is using MBeanUtils.encodeStr() for this.  For
consistancy, you might want to use change that to do ON.quote, or use
encodeStr here.



>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>


Mime
View raw message