tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 29472] - Embedded overrides add/remove Connector, but not findConnectors
Date Thu, 10 Jun 2004 17:11:54 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=29472>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=29472

Embedded overrides add/remove Connector, but not findConnectors





------- Additional Comments From arieh.markel@sun.com  2004-06-10 17:11 -------
Following Jan's comments and my inspection of the code of
Embedded and StandardService, it appears that there may still be several
issues laying around that could be resolved by a refactoring of many
of the methods.

I believe that the Listener subscription logic is duplicated.
It should be possible for the subclasses (Embedded) not to override the
variables nor the code.

The debug (variable, setter, getter) appears to be duplicated as well.
So is the Lifecycle creation.

Also, the start() method on both appears to not share the same activities
happening. Worthwhile to consider Embedded to invoke appropriately
super.start().

Similarly for stop().

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message