tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kin-Man Chung <Kin-Man.Ch...@Eng.Sun.COM>
Subject Re: Question on 5.0.23
Date Wed, 05 May 2004 18:22:33 GMT
Which watchdog is it?  Can you send me the other part (tld and tag handler)
of it?

If the tag is of a TAGDEPENDENT body type, then its body is should not
be evaluated.  It used to be evaluated in XML syntax, which is wrong and
which is what the patch intend to fix.  If this is the case, then the
golden file for the watchdog test should be replaced.

-Kin-man

> Date: Wed, 05 May 2004 02:26:32 +0200
> From: Remy Maucherat <remm@apache.org>
> Subject: Re: Question on 5.0.23
> To: Tomcat Developers List <tomcat-dev@jakarta.apache.org>
> 
> I have some possible problems with Jasper and XML syntax. One example 
> from old watchdog:
> 
> <jsp:root
> xmlns:jsp="http://java.sun.com/JSP/Page" version="1.2"
> xmlns:direct="urn:jsptld:/WEB-INF/tlds/example-taglib.tld"
>  >
> 
> <jsp:text><![CDATA[<html>
> <title>positiveDirectTldReference</title>
> <body>
> ]]></jsp:text>
> 
> <jsp:text><![CDATA[
> 
> ]]></jsp:text>
> <direct:test toBrowser="true" att1="att1">
> <jsp:text><![CDATA[
> Validated
> ]]></jsp:text>
> </direct:test>
> <jsp:text><![CDATA[
> </body>
> </html>
> ]]></jsp:text>
> 
> </jsp:root>
> 
> Generates for the tag:
> 
>          do {
>            out.write("<jsp:text>");
>            out.write("\n");
>            out.write("Validated\n");
>            out.write("</jsp:text>");
>            out.write('\n');
>            int evalDoAfterBody = _jspx_th_direct_test_0.doAfterBody();
>            member = (String) _jspx_page_context.findAttribute("member");
>            if (evalDoAfterBody != 
> javax.servlet.jsp.tagext.BodyTag.EVAL_BODY_AGAIN)
>              break;
>          } while (true);
> 
> So the tag body is not getting evaluated. I suspect this patch, which 
> was not yet present in 5.0.22:
> 
> kinman      2004/04/16 16:22:30
> 
>    Modified:    jasper2/src/share/org/apache/jasper/compiler
>                          JspDocumentParser.java
>    Log:
>    - Fix a bug where a custom tag with tagdependent body type is not
>      handled correctly in XML syntax.  The fix would have been trivial 
> if not
>      for the cases where <jsp:attribute> and/or <jsp:body> is present.
> 
> I'm not too big on tags though, so I don't know for sure if it's even a bug.
> 
> (et hop, 5.0.25 ... :/ )
> 
> Rémy
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message