tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Remy Maucherat <r...@apache.org>
Subject Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationContext.java
Date Fri, 02 Apr 2004 19:29:42 GMT
Mark Thomas wrote:

> OK then. Now for the tricky bit. Bug 13040
> (http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13040) highlights a rather
> knotty problem. Having mulled this over for the last few days I have come to the
> conclusion that we should be using equals() rather than startsWith()
> 
> My reasons for this are:
> - The spec says match which to my mind says equals()
> - It removes the need for special handling for root
> - It fixes bug 13040
> 
> However, changing this will break anything that assumes that the matching is
> performed on a startsWith() basis. This is bad. Have we ever received
> clarification from the spec team in this area? If not could someone point me
> towards someone who may be able to offer some advice.
> 
> As I see it there are three ways to deal with this:
> - ignore it - not an option I like
> - leave the code as is, closing bug 13040 as WONTFIX with an explantion as to
> why
> - make the change
> 
> Thoughts anyone?

The rest of the algorithm will do the startsWith, right ?
This is why I said it was a shortcut: it will handle the simple case 
where "/" is the parameter.

Rémy


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message