tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 18479] - HttpSessionBindingListener.valueUnbound() not called
Date Sun, 11 Apr 2004 11:28:32 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=18479>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=18479

HttpSessionBindingListener.valueUnbound() not called





------- Additional Comments From remm@apache.org  2004-04-11 11:28 -------
Please don't bother.

The new code  in writeObject is:
        // Accumulate the names of serializable and non-serializable attributes
        String keys[] = keys();
        ArrayList saveNames = new ArrayList();
        ArrayList saveValues = new ArrayList();
        for (int i = 0; i < keys.length; i++) {
            Object value = null;
            synchronized (attributes) {
                value = attributes.get(keys[i]);
            }
            if (value == null)
                continue;
            else if ( (value instanceof Serializable) 
                    && (!exclude(keys[i]) )) {
                saveNames.add(keys[i]);
                saveValues.add(value);
            } else {
                removeAttribute(keys[i]);
            }
        }

The change is the added removeAttribute. The patch which "broke" everything is
(this is the only difference between 5.0.20 and 5.0.21):
  diff -u -r1.40 -r1.41
  --- StandardSession.java	12 Mar 2004 22:36:46 -0000	1.40
  +++ StandardSession.java	25 Mar 2004 22:17:54 -0000	1.41
  @@ -1397,6 +1397,8 @@
                       && (!exclude(keys[i]) )) {
                   saveNames.add(keys[i]);
                   saveValues.add(value);
  +            } else {
  +                removeAttribute(keys[i]);
               }
           }

I doubt your "perfectly serializable" stuff actually is.

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message