Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
Date: Thu, 26 Feb 2004 18:48:18 +0100
From: Guenter Knauf <eflash@gmx.net>
Reply-To: Guenter Knauf <eflash@gmx.net>
To: tomcat-dev@jakarta.apache.org
Subject: Re: [PATCH] use ap_ prefixed PCRE functions - take 2
Message-ID: <zrUmiM3HaXtJHqNsmOh3k9TNHxC1eEMSQX2uAJgdmOb@akmail>
References: <U63G5VEimUyjEvBvkfrfEG4IyeVBm0qecwZei1Gy6jU@akmail>
 <02b801c3fc8c$d98ea0d0$200110ac@truk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Hi Kurt,
> I've reviewed your patch and have some comments included inline below.

> regcomp and ap_pregcomp are not interchangeable like this. ap_pregcomp
> needs an apr_pool to be passed to it and it returns the regex_t. I
> think (apr_pool_t *)uriEnv->pool->_private is correct here (Henri?,
> Jean-Frederic?).
for that I did the trick with '#define REGEX_POOL'...

> I'm not a fan of undef/def functions like this. If the functions were
> interchangeable, I would have just created a new define like PREGCOMP
> that points to the correct function.
I totally agree, but I wasnt sure what gets here more acceptance. I create a new patch shortly.

> Since Apache2 always comes with pcre whole define section would be
> better like this:

> #ifdef HAS_AP_PCRE
> #include "httpd.h"
> #else
> #ifdef HAS_PCRE
> #include "pcre.h"
> #include "pcreposix.h"
> #endif
> #endif

ok. Thanks for reviewing; I come up soon with a new patch with your suggestions.

Guenter.


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org