tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From G√ľnter Knauf <efl...@gmx.net>
Subject [PATCH] mod_jk2 - remove obsolete linefeeds from logs
Date Sun, 08 Feb 2004 17:15:31 GMT
Hi,
following patches remove obsolete linefeeds from the logs; the ap_log_* functions dont need
trailing linefeeds;
see also ./jk/native2/server/apache2/jk_logger_apache2.c line 132:
    /* Remove trailing \n. XXX need to change the log() to not include \n */

http://www.gknw.com/test/mod_jk2.c.diff
http://www.gknw.com/test/jk_service_apache2.c.diff

===================================================================================
--- ./jk/native2/server/apache2/mod_jk2.c.orig  Tue Sep 30 18:16:14 2003
+++ ./jk/native2/server/apache2/mod_jk2.c       Sun Feb 08 07:33:36 2004
@@ -141,7 +141,7 @@
     rc=workerEnv->config->setPropertyString( env, workerEnv->config, (char *)name,
value );
     if (rc!=JK_OK) {
         ap_log_perror(APLOG_MARK, APLOG_NOTICE, 0, cmd->temp_pool,
-                      "mod_jk2: Unrecognized option %s %s\n", name, value);
+                      "mod_jk2: Unrecognized option %s %s", name, value);
     }
 
     return NULL;
@@ -164,14 +164,14 @@
 
     if( name == NULL || property==NULL || value==NULL ) {
         ap_log_perror(APLOG_MARK, APLOG_NOTICE, 0, cmd->temp_pool,
-                      "mod_jk2: Null option in JkSet2\n");
+                      "mod_jk2: Null option in JkSet2");
         return NULL;
     }
     
     mbean=env->getBean( env, name );
     if( mbean==NULL ) {
         ap_log_perror(APLOG_MARK, APLOG_NOTICE, 0, cmd->temp_pool,
-                      "mod_jk2: Creating object %s\n", name );
+                      "mod_jk2: Creating object %s", name );
         mbean=env->createBean( env, workerEnv->config->pool, (char *)name );
     }
 
@@ -188,7 +188,7 @@
 
     if (rc!=JK_OK) {
         ap_log_perror(APLOG_MARK, APLOG_NOTICE, 0, cmd->temp_pool,
-                      "mod_jk2: Unrecognized option %s %s %s\n", name, property, value);
+                      "mod_jk2: Unrecognized option %s %s %s", name, property, value);
     }
 
     return NULL;
@@ -452,11 +452,11 @@
     if( s->is_virtual ) {
         /* Virtual host */
         ap_log_perror(APLOG_MARK, APLOG_DEBUG, 0, p,
-                      "mod_jk Create config for virtual host %s\n",
+                      "mod_jk Create config for virtual host %s",
                       s->server_hostname );
     } else {
         ap_log_perror(APLOG_MARK, APLOG_DEBUG, 0, p,
-                      "mod_jk Create config for default server %s\n",
+                      "mod_jk Create config for default server %s",
                       s->server_hostname );
     }
 
@@ -483,7 +483,7 @@
     jk_uriEnv_t *overrides = (jk_uriEnv_t *)overridesv;
     
     ap_log_perror(APLOG_MARK, APLOG_DEBUG, 0, p,
-                  "mod_jk Merging workerEnv\n");
+                  "mod_jk Merging workerEnv");
 
     
     /* The 'mountcopy' option should be implemented in common.

===================================================================================
--- ./jk/native2/server/apache2/jk_service_apache2.c.orig  Tue Feb 03 00:21:34 2004
+++ ./jk/native2/server/apache2/jk_service_apache2.c       Sun Feb 08 17:58:06 2004
@@ -311,7 +311,7 @@
      */
     if(ap_rflush(rr) != APR_SUCCESS) {
         ap_log_error(APLOG_MARK, APLOG_STARTUP | APLOG_NOERRNO, 0, 
-                     NULL, "mod_jk: Error flushing \n"  );
+                     NULL, "mod_jk: Error flushing"  );
         return JK_ERR;
     }


Guenter.


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message