tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 27307] New: - Suggestions to improve JNDI/DataSource Howto
Date Sat, 28 Feb 2004 01:50:22 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27307>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27307

Suggestions to improve JNDI/DataSource Howto

           Summary: Suggestions to improve JNDI/DataSource Howto
           Product: Tomcat 5
           Version: 5.0.19
          Platform: All
               URL: http://localhost:8080/tomcat-docs/jndi-datasource-
                    examples-howto.html
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: Webapps:Documentation
        AssignedTo: tomcat-dev@jakarta.apache.org
        ReportedBy: nagoya@felipeal.net


Hi all,

I've been reading the Howto and have some suggestions (specially regarding the
MySQL example):

- it's necessary to copy the JDBC driver jar on TOMCAT_HOME/common/lib

- you say: Please let us know if you have tested the new MySQL mm.mysql 3.0 driver. 

Well, I did (version 3.0.11-stable). It works the way it is, but I'd suggest you
update the howto to use the new driver. So, instead of :

    <!-- Class name for mm.mysql JDBC driver -->
    <parameter>
       <name>driverClassName</name>
       <value>org.gjt.mm.mysql.Driver</value>
    </parameter>

It should be:

    <!-- Class name for MySQL Connector/J driver -->
    <parameter>
       <name>driverClassName</name>
       <value>com.mysql.jdbc.Driver</value>
    </parameter>


- section 3 (web.xml configuration) uses the old web.xml format (Servlet 2.3):

<?xml version="1.0" encoding="ISO-8859-1"?>
    <!DOCTYPE web-app PUBLIC
    "-//Sun Microsystems, Inc.//DTD Web Application 2.3//EN"
    "http://java.sun.com/dtd/web-app_2_3.dtd">
<web-app>
  <description>MySQL Test App</description>
  <resource-ref>
      <description>DB Connection</description>
      <res-ref-name>jdbc/TestDB</res-ref-name>
      <res-type>javax.sql.DataSource</res-type>
      <res-auth>Container</res-auth>
  </resource-ref>
</web-app>

I know Tomcat 5 accepts both formats, but we should be "incentiving" people to
use the new one. So, it should be:

<?xml version="1.0" encoding="ISO-8859-1"?>
 
<web-app xmlns="http://java.sun.com/xml/ns/j2ee"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:schemaLocation="http://java.sun.com/xml/ns/j2ee
http://java.sun.com/xml/ns/j2ee/web-app_2_4.xsd"
    version="2.4">
    
  <description>MySQL Test App</description>
  <resource-ref>
      <description>DB Connection</description>
      <res-ref-name>jdbc/TestDB</res-ref-name>
      <res-type>javax.sql.DataSource</res-type>
      <res-auth>Container</res-auth>
  </resource-ref>

</web-app>

- section 4 (Test code). It would be nicer/simpler a JSTL/SQL example, like this:

<%@ taglib uri="http://java.sun.com/jsp/jstl/sql" prefix="sql" %>
<%@ taglib uri="http://java.sun.com/jsp/jstl/core" prefix="c" %>

<sql:query var="rs" dataSource="jdbc/TestDB">
select id, foo, bar from testdata
</sql:query>

<html>
  <head>
    <title>DB Test</title>
  </head>
  <body>

  <h2>Results</h2>
  
<c:forEach var="row" items="${rs.rows}">
    Foo ${row.foo}<br/>
    Bar ${row.bar}<br/>
</c:forEach>

  </body>
</html>



I can create a patch with these changes, if someone is willing to apply it (I'm
a committer on other projects, so I know how painful the process is :-).

Regards,

Felipe

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message