tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Barker" <wbar...@wilshire.com>
Subject Re: cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_worker_ajp13.c
Date Fri, 27 Feb 2004 18:34:54 GMT

----- Original Message -----
From: <hgomez@apache.org>
To: <jakarta-tomcat-connectors-cvs@apache.org>
Sent: Friday, February 27, 2004 1:07 AM
Subject: cvs commit: jakarta-tomcat-connectors/jk/native2/common
jk_worker_ajp13.c


> hgomez      2004/02/27 01:07:23
>
>   Modified:    jk/native2/common jk_worker_ajp13.c
>   Log:
>   Fix BR27281, when user stop its browser return 206 instead of 500
>
>   Revision  Changes    Path
>   1.60      +4 -0
jakarta-tomcat-connectors/jk/native2/common/jk_worker_ajp13.c
>
>   Index: jk_worker_ajp13.c
>   ===================================================================
>   RCS file:
/home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_worker_ajp13.c,v
>   retrieving revision 1.59
>   retrieving revision 1.60
>   diff -u -r1.59 -r1.60
>   --- jk_worker_ajp13.c 24 Feb 2004 08:44:40 -0000 1.59
>   +++ jk_worker_ajp13.c 27 Feb 2004 09:07:23 -0000 1.60
>   @@ -444,6 +444,10 @@
>                    s->is_recoverable_error = JK_FALSE;
>                    env->l->jkLog(env, env->l, JK_LOG_ERROR,
>                                  "ajp13.service() Error receiving initial
post %d %d %d\n", err, errno, attempt);
>   +
>   +                    /* BR #27281 : Should we return HTTP 500 since its
the user who stop the sending ? */
>   +                    /* may be not, so return another HTTP code -> use
PARTIAL CONTENT, 206 instead */
>   +                    s->status = 206;
>                    return JK_ERR;
>                }
>

IMHO, mod_jk2 shouldn't touch the status code in this case (since it can't
possibly be sent back to the client).  It should leave the status code as
whatever Tomcat set it to.

>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>


Mime
View raw message