tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Barker" <wbar...@wilshire.com>
Subject Re: Found it - WAS: Memory leak
Date Thu, 15 Jan 2004 20:17:51 GMT

----- Original Message -----
From: "Remy Maucherat" <remm@apache.org>
To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
Sent: Thursday, January 15, 2004 11:41 AM
Subject: Re: Found it - WAS: Memory leak


> Bill Barker wrote:
> >>Remy Maucherat wrote:
> >>
> >>>-1. There is no memory leak with this.
> >>>ByteChunks/CharChunks are always reused. If new ones are created, they
> >>>will be reused.
> >>
> >>Arg, I have to find something.
> >>I know ! It's all Costin's fault !
> >>
> >>I didn't think about the "scaling back" feature of the thread pool, to
> >>be honest. It should be very easy to avoid the problem, by setting
> >>maxSpareThreads to maxThreads.
> >
> > Also, Jk-Coyote doesn't pool threads, so the total number of Requests
> > created will (slowly) grow over time.
>
> I'm almost certain JK doesn't register the RequestInfo objects. It
> should (and it's a bug), but actually it doesn't. I tried to have the
> status servlet work with JK also, and had partial fixes, but in the end,
> I didn't find the feature too worthwhile (and my fixes were hacks), so I
> forgot about it (good thing I did).
>

It registers it on line 475 of HandlerRequest.  It's true that Jk doesn't do
much else with the RequestInfo, but it does register it.

> Rémy
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>


Mime
View raw message