Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
Message-ID: <3FD96FA6.8060906@purdue.edu>
Date: Fri, 12 Dec 2003 01:35:02 -0600
From: Reshat Sabiq <sabiq@purdue.edu>
Organization: ultranet.tv
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
 rv:1.4) Gecko/20030624 Netscape/7.1 (ax)
MIME-Version: 1.0
To: Tomcat Developers List <tomcat-dev@jakarta.apache.org>
Subject: Re: Likely bug in org.apache.jasper.servlet.JspServlet (Tomcat 5)
References: <3FD81C54.2010708@purdue.edu> <3FD83717.5030500@apache.org>
In-Reply-To: <3FD83717.5030500@apache.org>
Content-Type: multipart/signed; protocol="application/x-pkcs7-signature";
 micalg=sha1; boundary="------------ms040901050307070303040308"

--------------ms040901050307070303040308
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit


Remy Maucherat wrote:

> Reshat Sabiq wrote:
>
>> I think i found a bug in Tomcat 5 implementation (J2EE 1.4-DR). I 
>> would highly appreciate if somebody could provide a brief description 
>> of what includeUri, and requestUri below stand for. I looked at the 
>> comments in Constants, but can't make out a lot out of them. Please 
>> see my comment below.
>> org.apache.jasper.servlet.JspServlet.service() starting on line 190:
>>            String includeUri
>>                = (String) 
>> request.getAttribute(Constants.INC_SERVLET_PATH);
>>            String requestUri
>>                = (String) 
>> request.getAttribute(Constants.INC_REQUEST_URI);
>>                      String jspUri;
>>                      // When jsp-property-group/url-matching is used, 
>> and when the
>>            // jsp is not defined with <servlet-name>, the url
>>            // as to be passed as it is to the JSP container (since
>>            // Catalina doesn't know anything about the requested JSP
>>                      // The first scenario occurs when the jsp is not 
>> directly under /
>>            // example: /utf16/foo.jsp
>>            if (requestUri != null){
>>                ////////// This is pretty unsafe syntax, and i do get 
>> an exception here, which is the only reason why i can't migrate my 
>> app to J2EE 1.4-DR! ///////////
>>                String currentIncludedUri
>>                    = 
>> requestUri.substring(requestUri.indexOf(includeUri));                
>> if ( !includeUri.equals(currentIncludedUri) ) {
>>                    includeUri = currentIncludedUri;
>>                }
>>            }
>>
>> P.S. On a positive note, the custom error pages do work in DR, as 
>> opposed to Beta 2.
>
>
> This works fine for me. How about telling us what kind of include 
> causes your bug, and the exception you get ?
>
> R�my
>
I confirmed that it is a bug. It went further along after i put a 
conditional.
Now i'm getting an exception in:
<fmt:message key="better" bundle="${lc}" />
where lc is an instance variable of the jsp servlet: apparently it can't 
be resolved. It was working in Beta 2, so this might be a bug too.

Thanks.

P.S. I'll post the details later.

-- 
Sincerely,
Reshat.

-------------------------------------------------------------------------------------------
If you see my certificate with this message, you should be able to send me encrypted e-mail. 
Please consult your e-mail client for details if you would like to do that.


--------------ms040901050307070303040308
Content-Type: application/x-pkcs7-signature; name="smime.p7s"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="smime.p7s"
Content-Description: S/MIME Cryptographic Signature

MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIJQDCC
Av4wggJnoAMCAQICAwm57TANBgkqhkiG9w0BAQQFADCBkjELMAkGA1UEBhMCWkExFTATBgNV
BAgTDFdlc3Rlcm4gQ2FwZTESMBAGA1UEBxMJQ2FwZSBUb3duMQ8wDQYDVQQKEwZUaGF3dGUx
HTAbBgNVBAsTFENlcnRpZmljYXRlIFNlcnZpY2VzMSgwJgYDVQQDEx9QZXJzb25hbCBGcmVl
bWFpbCBSU0EgMjAwMC44LjMwMB4XDTAzMDQxMzE5NDI1MFoXDTA0MDQxMjE5NDI1MFowQjEf
MB0GA1UEAxMWVGhhd3RlIEZyZWVtYWlsIE1lbWJlcjEfMB0GCSqGSIb3DQEJARYQc2FiaXFA
cHVyZHVlLmVkdTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBALEeKHAltWSAM3of
s3ZOO9HSCI/qzr3WYrN3hAXvSl2JgFus5CD7+IMj27CIaA0xNQK00uX87+qfBAFcbRaqfWBN
oNK0rtQApudcoq+irtIRQdh5dbIS1xhIIJ6Ub06s6/tI7HNLPBsmZGbndm3WfrOvaGMPp6AZ
KAt7Hx9d1CD2YLnbv2Kqt8nui6eqjhnICfQvmfcn6y40bQpL98X3OtLSZSJnmzDqJuJhuidN
HpgARwAt7XUWcG34zKoPDjAOhA2N412jcW3lUkXLlXoev2UiDGEOVuHVjC52c3ahMCL/pZ8k
FBZxJKd/RlUOVdC2rNTHVHEYb+kfXO6XX5WqZ+8CAwEAAaMtMCswGwYDVR0RBBQwEoEQc2Fi
aXFAcHVyZHVlLmVkdTAMBgNVHRMBAf8EAjAAMA0GCSqGSIb3DQEBBAUAA4GBAG3uZqIKaD5n
HKc2KTdA/PQuxA+qaeS7OqdkknFO83FIEIjwL9CEwO+5YfInvDxE5f8J0kot30R0Fuczca43
JLKeH5L42cIOwkYk7hKv55QSsce8jy4YIa3A5dKXlueoYpw/l4Ti9wayj5bm4X6wuvE0jOtA
sHHUBrnCP/CL2M9wMIIC/jCCAmegAwIBAgIDCbntMA0GCSqGSIb3DQEBBAUAMIGSMQswCQYD
VQQGEwJaQTEVMBMGA1UECBMMV2VzdGVybiBDYXBlMRIwEAYDVQQHEwlDYXBlIFRvd24xDzAN
BgNVBAoTBlRoYXd0ZTEdMBsGA1UECxMUQ2VydGlmaWNhdGUgU2VydmljZXMxKDAmBgNVBAMT
H1BlcnNvbmFsIEZyZWVtYWlsIFJTQSAyMDAwLjguMzAwHhcNMDMwNDEzMTk0MjUwWhcNMDQw
NDEyMTk0MjUwWjBCMR8wHQYDVQQDExZUaGF3dGUgRnJlZW1haWwgTWVtYmVyMR8wHQYJKoZI
hvcNAQkBFhBzYWJpcUBwdXJkdWUuZWR1MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKC
AQEAsR4ocCW1ZIAzeh+zdk470dIIj+rOvdZis3eEBe9KXYmAW6zkIPv4gyPbsIhoDTE1ArTS
5fzv6p8EAVxtFqp9YE2g0rSu1ACm51yir6Ku0hFB2Hl1shLXGEggnpRvTqzr+0jsc0s8GyZk
Zud2bdZ+s69oYw+noBkoC3sfH13UIPZgudu/Yqq3ye6Lp6qOGcgJ9C+Z9yfrLjRtCkv3xfc6
0tJlImebMOom4mG6J00emABHAC3tdRZwbfjMqg8OMA6EDY3jXaNxbeVSRcuVeh6/ZSIMYQ5W
4dWMLnZzdqEwIv+lnyQUFnEkp39GVQ5V0Las1MdUcRhv6R9c7pdflapn7wIDAQABoy0wKzAb
BgNVHREEFDASgRBzYWJpcUBwdXJkdWUuZWR1MAwGA1UdEwEB/wQCMAAwDQYJKoZIhvcNAQEE
BQADgYEAbe5mogpoPmccpzYpN0D89C7ED6pp5Ls6p2SScU7zcUgQiPAv0ITA77lh8ie8PETl
/wnSSi3fRHQW5zNxrjcksp4fkvjZwg7CRiTuEq/nlBKxx7yPLhghrcDl0peW56hinD+XhOL3
BrKPlubhfrC68TSM60CwcdQGucI/8IvYz3AwggM4MIICoaADAgECAhBmRXK3zHT1z2N2RYTQ
LpEBMA0GCSqGSIb3DQEBBAUAMIHRMQswCQYDVQQGEwJaQTEVMBMGA1UECBMMV2VzdGVybiBD
YXBlMRIwEAYDVQQHEwlDYXBlIFRvd24xGjAYBgNVBAoTEVRoYXd0ZSBDb25zdWx0aW5nMSgw
JgYDVQQLEx9DZXJ0aWZpY2F0aW9uIFNlcnZpY2VzIERpdmlzaW9uMSQwIgYDVQQDExtUaGF3
dGUgUGVyc29uYWwgRnJlZW1haWwgQ0ExKzApBgkqhkiG9w0BCQEWHHBlcnNvbmFsLWZyZWVt
YWlsQHRoYXd0ZS5jb20wHhcNMDAwODMwMDAwMDAwWhcNMDQwODI3MjM1OTU5WjCBkjELMAkG
A1UEBhMCWkExFTATBgNVBAgTDFdlc3Rlcm4gQ2FwZTESMBAGA1UEBxMJQ2FwZSBUb3duMQ8w
DQYDVQQKEwZUaGF3dGUxHTAbBgNVBAsTFENlcnRpZmljYXRlIFNlcnZpY2VzMSgwJgYDVQQD
Ex9QZXJzb25hbCBGcmVlbWFpbCBSU0EgMjAwMC44LjMwMIGfMA0GCSqGSIb3DQEBAQUAA4GN
ADCBiQKBgQDeMzKmY8cJJUU+0m54J2eBxdqIGYKXDuNEKYpjNSptcDz63K737nRvMLwzkH/5
NHGgo22Y8cNPomXbDfpL8dbdYaX5hc1VmjUanZJ1qCeu2HL5ugL217CR3hzpq+AYA6h8Q0JQ
UYeDPPA5tJtUihOH/7ObnUlmAC0JieyUa+mhaQIDAQABo04wTDApBgNVHREEIjAgpB4wHDEa
MBgGA1UEAxMRUHJpdmF0ZUxhYmVsMS0yOTcwEgYDVR0TAQH/BAgwBgEB/wIBADALBgNVHQ8E
BAMCAQYwDQYJKoZIhvcNAQEEBQADgYEAMbFLR135AXHl9VNsXXnWPZjAJhNigSKnEvgilegb
SbcnewQ5uvzm8iTrkfq97A0qOPdQVahs9w2tTBu8A/S166JHn2yiDFiNMUIJEWywGmnRKxKy
QF1q+XnQ6i4l3Yrk/NsNH50C81rbyjz2ROomaYd/SJ7OpZ/nhNjJYmKtBcYxggPVMIID0QIB
ATCBmjCBkjELMAkGA1UEBhMCWkExFTATBgNVBAgTDFdlc3Rlcm4gQ2FwZTESMBAGA1UEBxMJ
Q2FwZSBUb3duMQ8wDQYDVQQKEwZUaGF3dGUxHTAbBgNVBAsTFENlcnRpZmljYXRlIFNlcnZp
Y2VzMSgwJgYDVQQDEx9QZXJzb25hbCBGcmVlbWFpbCBSU0EgMjAwMC44LjMwAgMJue0wCQYF
Kw4DAhoFAKCCAg8wGAYJKoZIhvcNAQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcN
MDMxMjEyMDczNTAyWjAjBgkqhkiG9w0BCQQxFgQUsrh9izD3NFTEqsxXeZ7W6DQM3bAwUgYJ
KoZIhvcNAQkPMUUwQzAKBggqhkiG9w0DBzAOBggqhkiG9w0DAgICAIAwDQYIKoZIhvcNAwIC
AUAwBwYFKw4DAgcwDQYIKoZIhvcNAwICASgwgasGCSsGAQQBgjcQBDGBnTCBmjCBkjELMAkG
A1UEBhMCWkExFTATBgNVBAgTDFdlc3Rlcm4gQ2FwZTESMBAGA1UEBxMJQ2FwZSBUb3duMQ8w
DQYDVQQKEwZUaGF3dGUxHTAbBgNVBAsTFENlcnRpZmljYXRlIFNlcnZpY2VzMSgwJgYDVQQD
Ex9QZXJzb25hbCBGcmVlbWFpbCBSU0EgMjAwMC44LjMwAgMJue0wga0GCyqGSIb3DQEJEAIL
MYGdoIGaMIGSMQswCQYDVQQGEwJaQTEVMBMGA1UECBMMV2VzdGVybiBDYXBlMRIwEAYDVQQH
EwlDYXBlIFRvd24xDzANBgNVBAoTBlRoYXd0ZTEdMBsGA1UECxMUQ2VydGlmaWNhdGUgU2Vy
dmljZXMxKDAmBgNVBAMTH1BlcnNvbmFsIEZyZWVtYWlsIFJTQSAyMDAwLjguMzACAwm57TAN
BgkqhkiG9w0BAQEFAASCAQCS6Fji7mJ7uGswkD4CJNsci+dAbP3RMvwVyNNJgyeHjN/OpO0C
txyXpO8xRQoLkYbs+T1jEnTd2TYg5+Pn1jIQF06PEYW+W/GKD0KBY4m4/AyftG/sG2LDmWmr
6ljLVxDRHYAcnBXCRLbs2ebwRgJMQUb8tqX5EIeyXe88UmefsaVXAwX8rbh6npex9Ar0Zvxd
E4oqYwIuH9lTx3+6BHX4j4KVGD8fVeSuN+N97MOL8Z+C8ZiyOVRgwJEZ/d1TYKAk5MsN8S60
yWvEP9hEqWQs4tHuVcOD/9Hlsh8xM60xLs04Ps68uMrsF4EQ1LuM5thuYDDQd884n9s0/liz
7n+5AAAAAAAA
--------------ms040901050307070303040308--