Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
Date: Wed, 10 Dec 2003 13:09:42 -0800
From: Amy Roh <amyroh@apache.org>
Subject: Re: cvs commit:
 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session
 StandardManager.java
To: Tomcat Developers List <tomcat-dev@jakarta.apache.org>
Message-id: <017201c3bf61$ee6ab790$0500a8c0@AMYROH>
MIME-version: 1.0
Content-type: text/plain; charset=iso-8859-1
Content-transfer-encoding: 8BIT
References: <20031205092855.69272.qmail@minotaur.apache.org>
 <3FD66185.60406@apache.org> <3FD67BA0.40900@apache.org>

> Amy Roh wrote:
> > remm@apache.org wrote:
> >
> >> remm        2003/12/05 01:28:55
> >>
> >>   Modified:    catalina/src/share/org/apache/catalina/session
> >>                         StandardManager.java
> >>   Log:
> >>   - isValid already expires sessions, so backgroundProcess shouldn't
call
> >>     expire again.
> >
> > isValid doesn't *always* expire session.
>  >
> > StandardSession.isValid() -
> >
> > public boolean isValid() {
> >
> >         if (this.expiring){
> >             return true;
> >         }
> >
> >         if (!this.isValid ) {
> > ***         return false;
> >         }
> >
> >         if (maxInactiveInterval >= 0) {
> >             long timeNow = System.currentTimeMillis();
> >             int timeIdle = (int) ((timeNow - lastAccessedTime) / 1000L);
> >             if (timeIdle >= maxInactiveInterval) {
> > ***             expire(true);
> >             }
> >         }
> >
> >         return (this.isValid);
> >     }
> >
> > If StandardSession.isValid is false, then we want to expire the session.
> >  However, isValid() call doesn't get to expire(true) and just return
> > false.  So removing session.expire() from
> > StandardManager.processExpires() won't work all the time.  Am I missing
> > something?
>
> There doesn't seem many methods changing isValid to false. invalidate is
> another one, and it calls expire. As long as all the methods which
> invalidate the session right away expire them, it should be ok I think.

IMHO, not calling expire() because no method changes isValid to false
doesn't seem like a clean approach.  Moreover,
PersistentManagerBase.processExpires() keeps expire() making it not
consistent.

Amy
>
> R�my
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org