tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Barker" <wbar...@wilshire.com>
Subject Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads ThreadPool.java
Date Thu, 25 Dec 2003 23:01:53 GMT

----- Original Message ----- 
From: "Remy Maucherat" <remm@apache.org>
To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
Sent: Thursday, December 25, 2003 1:15 AM
Subject: Re: cvs commit:
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads
ThreadPool.java


> billbarker@apache.org wrote:
> > billbarker    2003/12/24 19:08:31
> >
> >   Modified:    util/java/org/apache/tomcat/util/threads ThreadPool.java
> >   Log:
> >   Fix potential race condition.
> >
> >   You'll need some pretty high-end hardware to see this in the real
world, but it's still technically a bug.
>
> When can it occur, and what does the problem do ? All calls to
> openThreads are synced on the pool, so new threads should be created
> sequentially.
>

I was thinking that on a big enough SMP machine it would be possible to
check noThreadData before the constructor exists.  Of course, it's not since
the check is after the wait(), and notify() can't be called until the
constructor exits.  I realized this about half an hour after the commit, but
it didn't seem worth reverting.  I can revert it if people want.

> >   Revision  Changes    Path
> >   1.19      +1 -1
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads/ThreadPoo
l.java
> >
> >   Index: ThreadPool.java
> >   ===================================================================
> >   RCS file:
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads
/ThreadPool.java,v
> >   retrieving revision 1.18
> >   retrieving revision 1.19
> >   diff -u -r1.18 -r1.19
> >   --- ThreadPool.java 6 Nov 2003 19:05:23 -0000 1.18
> >   +++ ThreadPool.java 25 Dec 2003 03:08:31 -0000 1.19
> >   @@ -638,9 +638,9 @@
> >                t = new ThreadWithAttributes(p, this);
> >                t.setDaemon(true);
> >                t.setName(p.getName() + "-Processor" + p.getSequence());
> >   -            t.start();
> >                p.addThread( t, this );
> >        noThData=true;
> >   +            t.start();
> >            }
> >
> >            public void run() {
>
> Rémy
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>


Mime
View raw message