tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Barker" <wbar...@wilshire.com>
Subject Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm RealmBase.java
Date Fri, 12 Dec 2003 08:48:59 GMT

----- Original Message ----- 
From: "Remy Maucherat" <remm@apache.org>
To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
Sent: Thursday, December 11, 2003 11:55 PM
Subject: Re: cvs commit:
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm
RealmBase.java


> Remy Maucherat wrote:
>
> > Bill Barker wrote:
> >
> >> N.B. The Filter mapping code looks broken to me.  It looks like if I
> >> have a
> >> mapping for a url-pattern '*.jsp' that has
> >> <dispatcher>INCLUDE</dispatcher>,
> >> then it will incorrectly match a <jsp:include page="header.jspf" />.
> >>
> >> However, I haven't actually tested it. :).
> >
> >
> > I think there's an extra check for that case (this problem existed
> > previously). I'll check.
>
> I confirm that revision 1.10 of the filter factory fixed this.
>
> RCS file:
>
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/cor
e/ApplicationFilterFactory.java,v
> retrieving revision 1.9
> retrieving revision 1.10
> diff -r1.9 -r1.10
> 292c292,294
> <                 && (period != requestPath.length() - 1)) {
> ---
>  >                 && (period != requestPath.length() - 1)
>  >                 && ((requestPath.length() - period)
>  >                     == (testPath.length() - 1))) {
>
> So it compares the two extensions length, and was bug 22546.
>

So it does.  Apologies for misreading the code (and wasting your time).  And
it seems that through the magic of cut-and-paste, I've got the exact same
logic in the current security-constraint code ;).

> Rémy
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>


Mime
View raw message