Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
Message-ID: <3FB68A8D.60507@apache.org>
Date: Sat, 15 Nov 2003 21:20:29 +0100
From: Remy Maucherat <remm@apache.org>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
 rv:1.5) Gecko/20031007
MIME-Version: 1.0
To: Tomcat Developers List <tomcat-dev@jakarta.apache.org>
Subject: Re: cvs commit:
 jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5
 CoyoteConnector.java CoyoteRequest.java LocalStrings.properties
References: <20031115094502.63340.qmail@minotaur.apache.org>
 <3FB636DB.6040003@joedog.org>
In-Reply-To: <3FB636DB.6040003@joedog.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Tim Funk wrote:
> I like this idea. But if the client sends too much data, it appears 
> there will be no post data for the Servlet/JSP to process causing 
> strange user errors. (User: "Why is getParameter(...) null?")
> 
> Should an error of SC_REQUEST_ENTITY_TOO_LARGE be sent instead?  Of 
> course, checking this too early before the user has chance to use a 
> reader or input stream could also cause problems.

For now, the error is logged, and that's it.

> I guess I don't know what I want, but I wonder what to say in the future 
> in case the assumption above is correct and I see a tomcat-user post 
> about this.
> 
> Would it also be reasonable to allow a value of 0 (or -1) to disable 
> this feature?

-1 for unlimited sounds good to me. I should have tought about that. 
Good catch.

Remy


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org