tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Larry Isaacs" <Larry.Isa...@sas.com>
Subject RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteRequest.java
Date Thu, 20 Nov 2003 21:03:19 GMT
Hi Jan,

This looked like a good idea, so I ported it to Tomcat 4.1.x.
I'll go ahead and un-port it for consistincy with Tomcat 5.

Larry

> -----Original Message-----
> From: luehe@apache.org [mailto:luehe@apache.org] 
> Sent: Thursday, November 20, 2003 3:56 PM
> To: jakarta-tomcat-catalina-cvs@apache.org
> Subject: cvs commit: 
> jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/t
> omcat5 CoyoteRequest.java
> 
> 
> luehe       2003/11/20 12:56:28
> 
>   Modified:    catalina/src/share/org/apache/coyote/tomcat5
>                         CoyoteRequest.java
>   Log:
>   Backing out this change for the time being, as it breaks some of the
>   Servlet compatibility tests.
>   
>   I've suggested to the Servlet spec lead that the spec be 
> clarified to
>   say that an IllegalStateException is to be thrown if
>   ServletRequest.setCharacterEncoding() is called after the request
>   params/body have been read.
>   
>   Revision  Changes    Path
>   1.23      +4 -8      
> jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/t
> omcat5/CoyoteRequest.java
>   
>   Index: CoyoteRequest.java
>   ===================================================================
>   RCS file: 
> /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apach
> e/coyote/tomcat5/CoyoteRequest.java,v
>   retrieving revision 1.22
>   retrieving revision 1.23
>   diff -u -r1.22 -r1.23
>   --- CoyoteRequest.java	20 Nov 2003 01:14:31 -0000	1.22
>   +++ CoyoteRequest.java	20 Nov 2003 20:56:28 -0000	1.23
>   @@ -1493,10 +1493,6 @@
>        public void setCharacterEncoding(String enc)
>            throws UnsupportedEncodingException {
>    
>   -	if (requestParametersParsed || usingReader || 
> usingInputStream) {
>   -            return;
>   -        }
>   -  
>            // Ensure that the specified encoding is valid
>            byte buffer[] = new byte[1];
>            buffer[0] = (byte) 'a';
>   
>   
>   
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message