tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Luehe <Jan.Lu...@Sun.COM>
Subject Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Date Fri, 31 Oct 2003 00:18:09 GMT
Remy Maucherat wrote:
> Bill Barker wrote:
> 
>>> luehe@apache.org wrote:
>>>
>>>
>>>> luehe       2003/10/30 13:01:39
>>>>
>>>>  Modified:    util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
>>>>  Log:
>>>>  Fixed problem where if maxThreads is set to 1,
>>>>  ThreadPool.findControlRunnable() will log this error on the first
>>>>  request:
>>>>
>>>>    SEVERE: All threads (1) are currently busy, waiting. Increase
>>>>    maxThreads (1) or check the servlet status
>>>>
>>>>  and then block forever
>>>
>>>
>>> -1 for this patch.
>>> 1 is obviously a stupid configuration value, so the pool should 
>>> refuse it.
>>
>>
>> I agree with Remy:  The place to check this is ThreadPool.
> 
> 
> I'd like to add that my -1 is not because the patch is bad (the revised 
> algorithm seems ok), but because the 1 value doesn't make sense, so I 
> don't think there's a point adding a special case for it.

I guess I don't understand what makes "1" bad but "2" OK. Where do we 
draw the line of what is a stupid config?


Jan



---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message