Henri Gomez wrote:
> Remy Maucherat a écrit :
>
>> +0 if disabled by default; -1 otherwise.
>> All this stuff is inefficient, as it uses Strings. Ie, we take the
>> byte array we have for the header value, convert it to a String, and
>> then regexp will likely convert it to something else to work with it
>> (likely a char array). This is bad, obviously :-(
>>
>> I don't know if the JDK 1.4 stuff can work with bytes, but in any
>> case, the benchmarks seem a lot faster.
>>
>> So we need a simple byte-based regexp :) (sort of like the mapper)
>
>
> Well I take my inspiration from what is done in some TC 4.1 Valves...
I know ;-)
Some problematic stuff went away, though (the various mappers), but some
remain.
This feature would really need to be seriously optimized, as ideally
this would be enabled by default.
> We could do better as usually...
Yes.
Remy
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
|