tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Filip Hanik" <devli...@hanik.com>
Subject Re: TC4.1: StandardWrapperValve infinite recursion
Date Wed, 01 Oct 2003 22:17:18 GMT
My pardon on behalf of the dev community for lagging behind.

the fix has been made to the bug and committed to CVS.

commit message below

fhanik      2003/10/01 15:15:59

  Modified:    catalina/src/share/org/apache/catalina/core
                        StandardWrapperValve.java
  Log:
  bugzilla #19312
  fixed infinite recursive loop

  Revision  Changes    Path
  1.36      +7 -6
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardWrapp
erValve.java

  Index: StandardWrapperValve.java
  ===================================================================
  RCS file:
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/Sta
ndardWrapperValve.java,v
  retrieving revision 1.35
  retrieving revision 1.36
  diff -u -r1.35 -r1.36
  --- StandardWrapperValve.java 6 Feb 2003 22:06:33 -0000 1.35
  +++ StandardWrapperValve.java 1 Oct 2003 22:15:59 -0000 1.36
  @@ -518,8 +518,9 @@
               String containerName = null;
               if (container != null)
                   containerName = container.getName();
  -            log( "StandardWrapperValve[" + containerName
  -                       + "]: " + message, throwable);
  +            System.out.println( "StandardWrapperValve[" + containerName
  +                       + "]: " + message);
  +            throwable.printStackTrace(System.out);
           }

       }


----- Original Message -----
From: "Urban Widmark" <Urban.Widmark@enlight.net>
To: "Filip Hanik" <devlists@hanik.com>
Sent: Wednesday, October 01, 2003 3:00 PM
Subject: Re: TC4.1: StandardWrapperValve infinite recursion


On Tue, 30 Sep 2003, Filip Hanik wrote:

> are you able to work around the problem? ie, not using the logger, or is
> this something that is built into tomcat?

It is tomcat that is trying to use a logger that does not exist and the
problem is built into tomcat. The other log method in that class works
fine and there is no reason why the two should not work the same.

I could add a logger, but that would add a new logfile and we don't
want that.

What we will do is to apply the patch to tomcat and build it ourselves.
But that does not solve the root cause and pushes the burden of building
tomcat from source onto us. This is a trivial thing to fix, so I was just
wondering why it hasn't been.

/Urban


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message