Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm
Message-ID: <3F5AE281.7060606@apache.org>
Date: Sun, 07 Sep 2003 09:47:13 +0200
From: Remy Maucherat <remm@apache.org>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
 rv:1.4) Gecko/20030624
MIME-Version: 1.0
To: Tomcat Developers List <tomcat-dev@jakarta.apache.org>
Subject: Re: [PATCH] Bug 22666
References: <01C374CB.9061AF90.medthomas@ntlworld.com>
 <3F5AC97A.4010706@apache.org>
In-Reply-To: <3F5AC97A.4010706@apache.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Remy Maucherat wrote:

> I'll vote almost 2 ;-) No client I know of is always cosistently using 
> UTF8 to encode the URL, but however, I'm not sure clients are using the 
> encoding of the entity body to encode the URL.
> Proper character decoding of the decoded (it means %xx decoded here) URL 
> is already done (see CoyoteAdapter.convertURI), and there's a 
> connector.getURIEncoding() which is available to indicate what encoding 
> is to be used for the URL. Note: The default is US-ASCII (because 
> something else doesn't work), but you can be compliant with the W3C and 
> use UTF8 :) For more flexibility, we can use a new connector field for 
> that (let's call it connector.getQueryStringEncoding()), or use 
> connector.getURIEncoding(). This would be passed to the Parameters class 
> and used exclusively for the query string decoding (the POSTed stuff 
> won't use it, obviously). I want (I have to insist ;-) ) the default be 
> US-ASCII (so the feature will work in the real world) with a quick and 
> dirty B2C conversion in that particular case (like 
> CoyoteAdapter.convertURI).
> 
> Overall, this looks the most reasonable and flexible.
> 
> Note: If you want to code it, you'd better do it really fast ;-)

I've just committed a very simple implementation of this (without the 
extra queryStringEncoding field, although this is not hard to add).
Comments ?

Remy