Return-Path: Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Delivered-To: mailing list tomcat-dev@jakarta.apache.org Received: (qmail 62677 invoked from network); 7 Aug 2003 14:10:10 -0000 Received: from main.gmane.org (80.91.224.249) by daedalus.apache.org with SMTP; 7 Aug 2003 14:10:10 -0000 Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 19klSb-0003lY-00 for ; Thu, 07 Aug 2003 16:09:45 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: tomcat-dev@jakarta.apache.org Received: from news by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 19klSa-0003lL-00 for ; Thu, 07 Aug 2003 16:09:44 +0200 From: Costin Manolache Subject: Re: System.out refs Date: Thu, 07 Aug 2003 07:12:14 -0700 Lines: 31 Message-ID: References: <3F325CDC.8010503@joedog.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit X-Complaints-To: usenet@main.gmane.org User-Agent: KNode/0.7.2 Sender: news X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Tim Funk wrote: > When I was looking at o.a.c.core.ApplicationDispatcher.java, I noticed it > used 2 different logging styles: > > - Commons Logging > - log() which tries to use context.getLogger(), and if null uses > System.out > > Shouldn't the log() method use commons-logging if context.getLogger() > returns null? Yes, it should. Well, IMO the context logging should use commons-logging :-) > Bonus q: If anything uses System.out (including printStackTrace()) and > commons-logging is available - all System.outs should be converted to > commons-logging calls? Yes. Costin > > Are there any situations where using System.out is OK? > > > -Tim