Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm
Message-ID: <DE431F295862C24B8A5126CD96D5587D025B0451@MAIL>
From: Marc Saegesser <Marc.Saegesser@apropos.com>
To: Tomcat Developers List <tomcat-dev@jakarta.apache.org>
Subject: RE: [j-t-c] Thread problem in jk_uri_worker_map.c
Date: Sat, 30 Aug 2003 14:14:09 -0500
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Thanks.  I think I already do have karma for j-t-c.  I've been away =
from the
Jakarta projects for a long time, however, and I haven't been able to =
keep
up with what all the details of what's going on.  I didn't feel =
comfortable
coming back out of nowhere and checking in code right away since I know =
that
you are trying to get a release out.

-- Marc
=20

> -----Original Message-----
> From: Bill Barker [mailto:wbarker@wilshire.com]
> Sent: Friday, August 29, 2003 10:16 PM
> To: tomcat-dev@jakarta.apache.org
> Subject: Re: [j-t-c] Thread problem in jk_uri_worker_map.c
>=20
> I'll put this one in in the interest of time, but Marc should be =
given
> karma
> (like any other Tomcat committer) to j-t-c, if he doesn't have it =
already.
>=20
> "Marc Saegesser" <Marc.Saegesser@apropos.com> wrote in message
> news:DE431F295862C24B8A5126CD96D5587D025B0447@MAIL...
> Grrrr, the attachment got stripped from my last message.  Here's the =
diff
> inline:
>=20
> Index: jk_connect.c
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file:
> /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_connect.c,v
> retrieving revision 1.12
> diff -u -r1.12 jk_connect.c
> --- jk_connect.c 29 Aug 2003 13:07:52 -0000 1.12
> +++ jk_connect.c 29 Aug 2003 21:37:12 -0000
> @@ -101,6 +101,9 @@
>  #include "apr_general.h"
>  #endif
>=20
> +#if defined(WIN32)
> +typedef u_long in_addr_t;
> +#endif
>  /** resolve the host IP */
>=20
>  int jk_resolve(char *host,
>=20
>=20
> -- Marc
>=20
>=20
> > -----Original Message-----
> > From: Marc Saegesser [mailto:Marc.Saegesser@apropos.com]
> > Sent: Friday, August 29, 2003 4:41 PM
> > To: Tomcat Developers List
> > Subject: RE: [j-t-c] Thread problem in jk_uri_worker_map.c
> >
> > The file common/jk_connect.c no longer compiles on Win32 because =
the
> > in_addr_t type is not defined on that platform.  The attached patch
> fixes
> > the build problem, but there is probably a better way.
> >
> > -- Marc
> >
> >
> > > -----Original Message-----
> > > From: Glenn Nielsen [mailto:glenn@mail.more.net]
> > > Sent: Wednesday, August 27, 2003 8:55 AM
> > > To: Tomcat Developers List
> > > Subject: Re: [j-t-c] Thread problem in jk_uri_worker_map.c
> > >
> > > Henri Gomez wrote:
> > > > Marc Saegesser a =E9crit :
> > > >
> > > >> That makes sense.  The manipulations that map_uri_to_worker() =
does
> > > always
> > > >> make the string shorter so there is no need to worry about the
> > > modifiable
> > > >> string passed in being too short and needing reallocated.
> > > >>
> > > >> Trying to fix this in the jk/common code is, I think, a waste =
of
> > > effort.
> > > >>
> > > >> -- Marc
> > > >
> > > >
> > > > A good reason to have delayed jk 1.2.5 ;)
> > > >
> > >
> > > Ok, I have seen Henri's commit for the in_addr build fix.
> > > And I have seen Bill's patches for the uri mapping thread safe
> > > bug.
> > >
> > > If I don't hear about any more open items/bugs  for mod_jk 1.2.5 =
in
> the
> > > next
> > > few days I will generate another test release distribution over =
the
> > > weekend.
> > >
> > > Regards,
> > >
> > > Glenn
> > >
> > >
> > > =
---------------------------------------------------------------------
> > > To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> > > For additional commands, e-mail: =
tomcat-dev-help@jakarta.apache.org
> >
>=20
>=20
>=20
>=20
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org