Return-Path: <amyroh@apache.org>
Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm
Delivered-To: mailing list tomcat-dev@jakarta.apache.org
Received: (qmail 95280 invoked from network); 26 Aug 2003 22:01:04 -0000
Received: from unknown (HELO nwkea-mail-1.sun.com) (192.18.42.13)
  by daedalus.apache.org with SMTP; 26 Aug 2003 22:01:04 -0000
Received: from phys-d3-ha21sca-1 ([129.145.155.163])
	by nwkea-mail-1.sun.com (8.12.9/8.12.9) with ESMTP id h7QLxKHY001602
	for <tomcat-dev@jakarta.apache.org>; Tue, 26 Aug 2003 15:01:07 -0700 (PDT)
Received: from apache.org (d-sfo06-83-218.Eng.Sun.COM [129.144.83.218])
 by ha21sca-mail1.sfbay.sun.com
 (iPlanet Messaging Server 5.2 HotFix 1.16 (built May 14 2003))
 with ESMTP id <0HK800CPDYF5SF@ha21sca-mail1.sfbay.sun.com> for
 tomcat-dev@jakarta.apache.org; Tue, 26 Aug 2003 15:00:11 -0700 (PDT)
Date: Tue, 26 Aug 2003 15:02:22 -0700
From: Amy Roh <amyroh@apache.org>
Subject: Re: [VOTE] 5.0.9 stability rating
In-reply-to: <3F4BB0F4.1080205@apache.org>
To: Tomcat Developers List <tomcat-dev@jakarta.apache.org>
Message-id: <3F4BD8EE.6060207@apache.org>
MIME-version: 1.0
Content-type: text/plain; format=flowed; charset=us-ascii
Content-transfer-encoding: 7bit
X-Accept-Language: en-us, en
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4)
 Gecko/20030624
References: <20030822164720.11329.qmail@nagoya.betaversion.org>
 <3F4650F4.6040109@apache.org> <00bf01c368ed$40b57ec0$ec66a8c0@bbarkerxp>
 <3F4A3FE1.5030504@apache.org> <3F4A4818.6040501@apache.org>
 <3F4A8BB0.5000600@apache.org> <3F4BA2F8.80706@apache.org>
 <3F4BB0F4.1080205@apache.org>
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

Resend.  It's been almost 3 hours since I sent the original email. 
wonder if it's my mail server or apache...

Amy Roh wrote:

> Remy Maucherat wrote:
> 
>> Amy Roh wrote:
>>
>>> Remy Maucherat wrote:
>>>
>>>> Amy Roh wrote:
>>>>
>>>>> I'll update the mbean-descriptor.xml and admin page for Connector 
>>>>> soon.
>>>>
>>>>
>>>>
>>>>
>>>> Thanks. Sorry for the trouble.
>>>
>>>
>>>
>>>
>>> No Problem.  I just committed the updates.  Let me know if there is 
>>> additional updates or if I missed/overlooked anything.
>>
>>
>>
>> The changes are a bit more complex than what you did. The new syntax is:
>>
>> HTTP/1.1:
>>
>>     <Connector port="8080"
>>                maxThreads="150" minSpareThreads="25" maxSpareThreads="75"
>>                enableLookups="false" redirectPort="8443" 
>> acceptCount="100"
>>                debug="0" connectionTimeout="20000"
>>                disableUploadTimeout="true" />
>> (the thread pool configuration changed, basically)
>>
>> AJP/1.3:
>>
>>     <Connector port="8009"
>>                enableLookups="false" redirectPort="8443" debug="0"
>>                protocol="AJP/1.3" />
>> (ie, no thread pool configuration here)
>>
>> Please don't add get/set on the CoyoteConnector class itself (we're 
>> trying to avoid that, as it's protocol dependent; you can look at 
>> Bill's patch - which I reverted for performance reasons, but which did 
>> the right thing on principle). IMO, you should add those to the 
>> ConnectorMBean, and use get/setProperty. What do you think ?
> 
> 
> I thought we're moving away from using *MBean classes and instead using 
> the actual class for management implementation.  But I see that why we 
> want to avoid the getters and setters from the class due to protocol 
> dependency.  We can definitely move the getters/setters into a 
> ConnectorMBean as long as modeler keeps supporting extending class 
> mbean.  I can either update o.a.c.mbeans.ConnectorMBean and use it or 
> put the ConnectorMBean in the coyote directory with the mbean-descriptor 
> and the Connector class.  I'll need to update admin to represent thread 
> pool configuration changes.
> 
> Amy
> 
>>
>> Remy
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>>
> 
>