Return-Path: Delivered-To: apmail-jakarta-tomcat-dev-archive@apache.org Received: (qmail 63870 invoked from network); 12 Aug 2003 00:22:22 -0000 Received: from exchange.sun.com (192.18.33.10) by daedalus.apache.org with SMTP; 12 Aug 2003 00:22:22 -0000 Received: (qmail 19996 invoked by uid 97); 12 Aug 2003 00:25:09 -0000 Delivered-To: qmlist-jakarta-archive-tomcat-dev@nagoya.betaversion.org Received: (qmail 19989 invoked from network); 12 Aug 2003 00:25:09 -0000 Received: from daedalus.apache.org (HELO apache.org) (208.185.179.12) by nagoya.betaversion.org with SMTP; 12 Aug 2003 00:25:09 -0000 Received: (qmail 63046 invoked by uid 500); 12 Aug 2003 00:22:12 -0000 Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Tomcat Developers List" Reply-To: "Tomcat Developers List" Delivered-To: mailing list tomcat-dev@jakarta.apache.org Received: (qmail 63033 invoked from network); 12 Aug 2003 00:22:11 -0000 Received: from brmea-mail-3.sun.com (192.18.98.34) by daedalus.apache.org with SMTP; 12 Aug 2003 00:22:11 -0000 Received: from phys-d3-ha21sca-1 ([129.145.155.163]) by brmea-mail-3.sun.com (8.12.9/8.12.9) with ESMTP id h7C0MJPr002614 for ; Mon, 11 Aug 2003 18:22:20 -0600 (MDT) Received: from sun.com (raga2.SFBay.Sun.COM [129.145.132.30]) by ha21sca-mail1.sfbay.sun.com (iPlanet Messaging Server 5.2 HotFix 1.16 (built May 14 2003)) with ESMTP id <0HJH0014GD172D@ha21sca-mail1.sfbay.sun.com> for tomcat-dev@jakarta.apache.org; Mon, 11 Aug 2003 17:22:19 -0700 (PDT) Date: Mon, 11 Aug 2003 17:22:19 -0700 From: Jan Luehe Subject: Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Protocol.java To: Tomcat Developers List Reply-to: Jan.Luehe@Sun.COM Message-id: <3F38333B.3090101@sun.com> MIME-version: 1.0 Content-type: text/plain; format=flowed; charset=us-ascii Content-transfer-encoding: 7bit X-Accept-Language: en-US User-Agent: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.1) Gecko/20020827 References: <20030811214449.14182.qmail@minotaur.apache.org> <3F3811D0.5030008@apache.org> X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Remy Maucherat wrote: > luehe@apache.org wrote: > >> luehe 2003/08/11 14:44:49 >> + public void setProtocols(String k) { >> + setAttribute("protocols", k); >> + } >> + > > > This probably should be "sslProtocols", no ? Hmm, but that would make it inconsistent with Http11Protocol's "setProtocol" method, which sets an attribute named "protocol". Remember I raised this issue after adding the "sslProtocol" property to CoyoteConnector? > >>> Added new "sslProtocol" property + minor javadoc edits > >>> > >>> The "protocol" property is a little confusing, as it means different > >>> things in different classes: > >>> > >>> - In CoyoteConnector, it refers to the Coyote protocol name (i.e., > >>> HTTP/1.1 or AJP/1.3). > >>> > >>> - In Http11Processor and CoyoteServerSocketFactory, it refers to the > >>> SSL protocol variant. > >>> > >>> We may want to fix this. > >> > >>Well, protocol for HTTP and AJP is the accurate name. Protocol for the > >>secure layer is also the right name (note that this parameter is > >>remarkably useless, as everything supports TLS now, and the old SSL2 is > >>supposedly insecure). My understanding is that the property names are mapped as follows: Connector Http11Protocol -------------------------------------- sslProtocol(s) -> protocol(s) Jan --------------------------------------------------------------------- To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org