tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Glenn Nielsen <gl...@mail.more.net>
Subject Re: [VOTE] Release mod_jk 1.2.5
Date Fri, 01 Aug 2003 13:41:30 GMT
I can confirm what Henri said, laddr had always been a ulong and
was only type in_addr_t for a short period of time.

Does mod_jk 1.2.4 build and work correctly?  It used a ulong for laddr.

What web server are you building this for?

If you are building for Apache 2 it may be a problem with the APR code.

Regards,

Glenn

Kurt Miller wrote:
> From: "Glenn Nielsen" <glenn@mail.more.net>
> To: <tomcat-dev@jakarta.apache.org>
> Sent: Friday, August 01, 2003 6:39 AM
> Subject: [VOTE] Release mod_jk 1.2.5
> 
> 
> 
>>No problems have been reported since the last test source distribution
>>of mod_jk 1.2.5 was made available for testing July 26.
>>
> 
> 
> I've found one problem on the OpenBSD/sparc64 platform in jk_resolve. The
> recent change of the datatype of laddr from in_addr_t to u_long has broken
> this function. Could this be reverted back before release? Below is a copy
> of the commit that caused the problem:
> 
> hgomez      2003/07/25 07:58:22
> 
>   Modified:    jk/native/common jk_connect.c
>   Log:
>   Use u_long instead of in_addr_t which make unhappy some platforms like
> iSeries
> 
> 
>   Revision  Changes    Path
>   1.10      +2 -3
> jakarta-tomcat-connectors/jk/native/common/jk_connect.c
> 
>   Index: jk_connect.c
>   ===================================================================
>   RCS file:
> /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_connect.c,v
>   retrieving revision 1.9
>   retrieving revision 1.10
>   diff -u -r1.9 -r1.10
>   --- jk_connect.c 24 Jul 2003 08:17:10 -0000 1.9
>   +++ jk_connect.c 25 Jul 2003 14:58:22 -0000 1.10
>   @@ -110,8 +110,7 @@
>        int x;
> 
>        /* TODO: Should be updated for IPV6 support. */
>   -    /* for now use the correct type, in_addr_t */
>   -    in_addr_t laddr;
>   +    u_long laddr;
> 
>        rc->sin_port   = htons((short)port);
>        rc->sin_family = AF_INET;
> 
> -Kurt
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> 



Mime
View raw message