Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
Date: Mon, 21 Jul 2003 18:36:37 -0700
From: Jan Luehe <Jan.Luehe@Sun.COM>
Subject: Re: cvs commit:
 jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet
 JspServlet.java
To: Tomcat Developers List <tomcat-dev@jakarta.apache.org>
Reply-to: Jan.Luehe@Sun.COM
Message-id: <3F1C9525.1000605@sun.com>
MIME-version: 1.0
Content-type: text/plain; format=flowed; charset=us-ascii
Content-transfer-encoding: 7bit
User-Agent: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.1) Gecko/20020827
References: <20030721190635.2717.qmail@icarus.apache.org>
 <3F1C3BF5.20701@apache.org>

>>   +
>>   +        /*
>>   +         * Add X-Powered-By header for JSP, if Catalina already 
>> added a
>>   +         * corresponding header for servlets
>>   +         */
>>   +        if (response.containsHeader("X-Powered-By")) {
>>   +        response.addHeader("X-Powered-By", "JSP/2.0");
>>   +        }
>>   +
> 
> 
> This is a pretty bad implementation IMO.
> What's the use of disabling this feature ?

The spec declares these headers as optional, which means Tomcat should 
make them configurable. Some sites may prefer not to include this 
information in their responses, for security reasons or whatever.

> -1 on the various flags and checks (just add the headers, without flags 
> and complexity). -0 if you can indicate a good reason for this.
> Also, you shouldn't add the JSP 2.0 header in JspServlet. If you 
> precompile, it's not called. Put it in HttpJspBase.

I had thought about adding the JSP 2.0 header in HttpJspBase, but then 
realized that the "extends" page directive allows you to specify the 
class that the generated servlet should extend, in which case 
HttpJspBase will be out of the picture. Do you have a better idea?


Jan


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org