tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Remy Maucherat <r...@apache.org>
Subject Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteConnector.java CoyoteRequest.java
Date Thu, 10 Jul 2003 23:48:59 GMT
Jan Luehe wrote:
> Remy,
> 
>>> luehe       2003/07/10 08:51:40
>>>
>>>   Modified:    catalina/src/share/org/apache/coyote/tomcat5
>>>                         CoyoteConnector.java CoyoteRequest.java
>>>   Log:
>>>   Consider CoyoteConnector's bufferSize property when creating 
>>> CoyoteRequest objects
>>
>>
>>
>> Why break the no arg constructor design ? The buffer size should be 
>> set to the default of the servlet API, and the buffer will just have 
>> to grow a few times, so there's no performance impact. Is there a real 
>> justification for this change ?
> 
> 
> The only reason for this change is that I don't see where the 
> connector's 'bufferSize' property is currently being used.
> 
> If it's not used at all, we may want to start using it or remove it 
> altogether.
> 
> Do you agree?

Well, yes. The default buffer size is forced by the servlet API, and 
then it can be changed with setBufferSize. If something is not used, 
then it would seem it can be removed. Maybe it was a parameter which 
existed in the old connector ...

Remy


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message