tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Remy Maucherat <r...@apache.org>
Subject Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java
Date Sat, 05 Jul 2003 05:16:02 GMT
billbarker@apache.org wrote:
> billbarker    2003/07/04 18:39:42
> 
>   Modified:    http11/src/java/org/apache/coyote/http11
>                         Http11Processor.java
>   Log:
>   Reverting previous patch.
>   
>   I included the code that httpd actually uses, in case somebody else likes the idea.

> However, I left it commented out, so that the only effect it has to to add a few bytes
to the .class file.
>  If nobody else likes the idea, I'll clean it out later.

>   +    /**
>   +     * Determine if we must drop the connection because of the HTTP status
>   +     * code.  Use the same list of codes as Apache/httpd.
>   +     */
>   +    protected boolean statusDropsConnection(int status) {
>   +        return status == 400 /* SC_BAD_REQUEST */ ||
>   +               status == 408 /* SC_REQUEST_TIMEOUT */ ||
>   +               status == 411 /* SC_LENGTH_REQUIRED */ ||
>   +               status == 413 /* SC_REQUEST_ENTITY_TOO_LARGE */ ||
>   +               status == 414 /* SC_REQUEST_URI_TOO_LARGE */ ||
>   +               status == 500 /* SC_INTERNAL_SERVER_ERROR */ ||
>   +               status == 503 /* SC_SERVICE_UNAVAILABLE */ ||
>   +               status == 501 /* SC_NOT_IMPLEMENTED */;
>   +    }

I like the list contents. Very sensible (silly me for doubting the HTTPd 
folks ;-) ).

+1 for uncommenting the patch.

BTW, I don't know if the exception field is correctly set on the 
Response object. If it is set, it's also a good reason to disconnect (IMO).

I'm off for the WE :)
For info, I plan to tag 4.1.25 early next week.

Remy


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message