tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 21908] - Fix for Yaov's 4.1.26 annoyance
Date Mon, 28 Jul 2003 15:02:34 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21908>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21908

Fix for Yaov's 4.1.26 annoyance

jcorley1@nc.rr.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |



------- Additional Comments From jcorley1@nc.rr.com  2003-07-28 15:02 -------
Not to be a pain in the butt, but the below fix isn't the patch I submitted in
the bug report.  In addition, the patch submitted changes the desired effect of
that block of code (from a check for existence to a check for non-existance).  I
was going to submit a patch at some point to change all of that syntax to
explicit test checks.  So I recommend changing:
    if $foo; then
To:
    if [ "$foo" ]; then
precisely to avoid errors like this and the one that required the patch I sent
in originally.
Jason

-----

funkman     2003/07/26 07:27:54

  Modified:    catalina/src/bin setclasspath.sh
  Log:
  Per bugzilla 21908
  Thanks jcorley1 AT nc.rr dot com (Jason Corley)
  
  Revision  Changes    Path
  1.10      +2 -2      jakarta-tomcat-4.0/catalina/src/bin/setclasspath.sh
  
  Index: setclasspath.sh
  ===================================================================
  RCS file: /home/cvs/jakarta-tomcat-4.0/catalina/src/bin/setclasspath.sh,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- setclasspath.sh   8 May 2003 08:19:58 -0000       1.9
  +++ setclasspath.sh   26 Jul 2003 14:27:54 -0000      1.10
  @@ -10,7 +10,7 @@
     echo "This environment variable is needed to run this program"
     exit 1
   fi
  -if $os400; then
  +if [ ! "$os400" ]; then
     if [ ! -r "$JAVA_HOME"/bin/java -o ! -r "$JAVA_HOME"/bin/javac ]; then
       echo "The JAVA_HOME environment variable is not defined correctly"
       echo "This environment variable is needed to run this program"

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message