Return-Path: Delivered-To: apmail-jakarta-tomcat-dev-archive@apache.org Received: (qmail 74517 invoked from network); 17 Jun 2003 18:57:31 -0000 Received: from exchange.sun.com (192.18.33.10) by daedalus.apache.org with SMTP; 17 Jun 2003 18:57:31 -0000 Received: (qmail 21034 invoked by uid 97); 17 Jun 2003 18:59:54 -0000 Delivered-To: qmlist-jakarta-archive-tomcat-dev@nagoya.betaversion.org Received: (qmail 21027 invoked from network); 17 Jun 2003 18:59:53 -0000 Received: from daedalus.apache.org (HELO apache.org) (208.185.179.12) by nagoya.betaversion.org with SMTP; 17 Jun 2003 18:59:53 -0000 Received: (qmail 78559 invoked by uid 500); 17 Jun 2003 17:51:46 -0000 Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Tomcat Developers List" Reply-To: "Tomcat Developers List" Delivered-To: mailing list tomcat-dev@jakarta.apache.org Received: (qmail 78493 invoked from network); 17 Jun 2003 17:51:45 -0000 Received: from icarus.apache.org (208.185.179.13) by daedalus.apache.org with SMTP; 17 Jun 2003 17:51:45 -0000 Received: (qmail 35002 invoked from network); 17 Jun 2003 17:51:41 -0000 Received: from unknown (HELO apache.org) (127.0.0.1) by localhost.apache.org with SMTP; 17 Jun 2003 17:51:41 -0000 Message-ID: <3EEF54C0.8060505@apache.org> Date: Tue, 17 Jun 2003 19:49:52 +0200 From: Remy Maucherat Organization: ASF User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3) Gecko/20030312 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java References: <20030617013112.14292.qmail@icarus.apache.org> In-Reply-To: <20030617013112.14292.qmail@icarus.apache.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: localhost.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N funkman@apache.org wrote: > funkman 2003/06/16 18:31:12 > > Modified: catalina/src/conf web.xml > catalina/src/share/org/apache/catalina/servlets > DefaultServlet.java > Log: > - Allow a site (webapp) wide xslt transformation for look (real file name) > - Allow per directory xslt transformation for customized look > - Allow a readme file to be rendered with the directory listing > - fix typo in row color when trying to gray bar lines > > Any suggestions on not making globalXsltFile a real file but still > cross webapp app friendly? Good idea (the readme is very Apache like; I like it), but IMO the code is a bit too complex for what it wants to achieve. To access a resource (such as the XSL stylesheet and readme file), you don't need ResourceInfo (which is a placeholder for many things other than the binary content). You should do a lookup on the resources DirContext, cast that to Resource, and use getContent (and if somehow it returns null, fall back to using streamContent). Remy --------------------------------------------------------------------- To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org