Return-Path: Delivered-To: apmail-jakarta-tomcat-dev-archive@apache.org Received: (qmail 99716 invoked from network); 6 Jun 2003 06:49:18 -0000 Received: from exchange.sun.com (192.18.33.10) by daedalus.apache.org with SMTP; 6 Jun 2003 06:49:18 -0000 Received: (qmail 12816 invoked by uid 97); 6 Jun 2003 06:51:43 -0000 Delivered-To: qmlist-jakarta-archive-tomcat-dev@nagoya.betaversion.org Received: (qmail 12809 invoked from network); 6 Jun 2003 06:51:42 -0000 Received: from daedalus.apache.org (HELO apache.org) (208.185.179.12) by nagoya.betaversion.org with SMTP; 6 Jun 2003 06:51:42 -0000 Received: (qmail 98840 invoked by uid 500); 6 Jun 2003 06:49:07 -0000 Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Tomcat Developers List" Reply-To: "Tomcat Developers List" Delivered-To: mailing list tomcat-dev@jakarta.apache.org Received: (qmail 98785 invoked from network); 6 Jun 2003 06:49:07 -0000 Received: from icarus.apache.org (208.185.179.13) by daedalus.apache.org with SMTP; 6 Jun 2003 06:49:07 -0000 Received: (qmail 62542 invoked from network); 6 Jun 2003 06:49:04 -0000 Received: from unknown (HELO apache.org) (127.0.0.1) by localhost.apache.org with SMTP; 6 Jun 2003 06:49:04 -0000 Message-ID: <3EE0396C.1090406@apache.org> Date: Fri, 06 Jun 2003 08:49:16 +0200 From: Remy Maucherat Organization: ASF User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3) Gecko/20030312 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteRequest.java References: <20030606030333.30819.qmail@icarus.apache.org> <3EE0356C.3040803@apache.org> <011701c32bf8$3e2e2080$d2b32b04@dslverizon.net> In-Reply-To: <011701c32bf8$3e2e2080$d2b32b04@dslverizon.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: localhost.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Bill Barker wrote: >>I'm -1 on this patch unless you can explain what the bug exactly was, >>and how the recycling couldn't properly reset the facade. > > I'm not really happy with the patch either. I'll postpone adding my (since > it's the second, binding) -1 until you provide a better explaination. Well, I have no idea what the bug report mentioned looks like, so I can't provide a real evaluation. However, what I'm now pretty sure about is that the patch is possibly unsafe. Note: AFAIK, one -1 is enough. Remy --------------------------------------------------------------------- To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org