tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Remy Maucherat <r...@apache.org>
Subject Re: [PATCH] Change getSession() in org.apache.catalina.Session from HttpSession to a more general interface (enhancement request 21169)
Date Sun, 29 Jun 2003 21:18:12 GMT
Brian Olsen wrote:
> Hey Guys,
> 
> I just made a proposed patch for the enhancement request I made 
> regarding the SIP Servlet API
> http://issues.apache.org/bugzilla/show_bug.cgi?id=21169
> 
> It adds a new interface org.apache.catalina.ServletSession that contains 
> the methods that HttpSession has in common with
> SipSession and SipApplicationSession.
> 
> The interface changes are non-intrusive meaning that it changes or adds 
> no functionality so if a class implements HttpSession it will also
> implement all the methods in ServletSession.
> 
> To make catalina support the new interface have have made the following 
> changes:
> org.apache.catalina.Session - changed to return a ServletSession in the 
> getSession() method
> org.apache.catalina.session.StandardSession - makes it implement 
> ServletSession and typecasts to HttpSession where needed.
> org.apache.catalina.session.StandardSessionFacade - makes it implement 
> ServletSession
> org.apache.coyote.tomcat5.CoyoteRequest - typecasts from ServletSession 
> to HttpSession in the getSession( boolean )

I'm not that thrilled by the patch, because we made the decision in TC 5 
to work only with the HTTP protocol, for complexity reasons. Actually, 
it's merely the underlying protocol having to behave like HTTP (although 
the older TC 4.0 was supposedly protocol generic, it ended up being 
designed with HTTP in mind, so it wasn't much better).

I know a bit the SIP spec, and that patch would sove the problem for 
sessions. How do you plan to solve it for the connector ?
(the idea is that Coyote - supporting HTTP and JK - will remain the only 
supported connector in TC 5, the internal Catalina API being conserved 
for compatibility, or at least easy porting, of any old Catalina module)

Remy


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message