tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Remy Maucherat <r...@apache.org>
Subject Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteRequest.java
Date Fri, 06 Jun 2003 06:49:16 GMT
Bill Barker wrote:
>>I'm -1 on this patch unless you can explain what the bug exactly was,
>>and how the recycling couldn't properly reset the facade.
> 
> I'm not really happy with the patch either.  I'll postpone adding my (since
> it's the second, binding) -1 until you provide a better explaination.

Well, I have no idea what the bug report mentioned looks like, so I 
can't provide a real evaluation. However, what I'm now pretty sure about 
is that the patch is possibly unsafe.

Note: AFAIK, one -1 is enough.

Remy


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message