Return-Path: Delivered-To: apmail-jakarta-tomcat-dev-archive@apache.org Received: (qmail 64262 invoked from network); 22 May 2003 20:43:05 -0000 Received: from exchange.sun.com (192.18.33.10) by daedalus.apache.org with SMTP; 22 May 2003 20:43:05 -0000 Received: (qmail 21711 invoked by uid 97); 22 May 2003 20:45:19 -0000 Delivered-To: qmlist-jakarta-archive-tomcat-dev@nagoya.betaversion.org Received: (qmail 21704 invoked from network); 22 May 2003 20:45:18 -0000 Received: from daedalus.apache.org (HELO apache.org) (208.185.179.12) by nagoya.betaversion.org with SMTP; 22 May 2003 20:45:18 -0000 Received: (qmail 63421 invoked by uid 500); 22 May 2003 20:42:53 -0000 Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Tomcat Developers List" Reply-To: "Tomcat Developers List" Delivered-To: mailing list tomcat-dev@jakarta.apache.org Received: (qmail 63410 invoked from network); 22 May 2003 20:42:53 -0000 Received: from icarus.apache.org (208.185.179.13) by daedalus.apache.org with SMTP; 22 May 2003 20:42:53 -0000 Received: (qmail 89478 invoked from network); 22 May 2003 20:42:51 -0000 Received: from unknown (HELO apache.org) (127.0.0.1) by localhost.apache.org with SMTP; 22 May 2003 20:42:51 -0000 Message-ID: <3ECD3650.7050401@apache.org> Date: Thu, 22 May 2003 22:42:56 +0200 From: Remy Maucherat Organization: ASF User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3) Gecko/20030312 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationContext.java LocalStrings.properties StandardContext.java References: <20030519215408.99246.qmail@icarus.apache.org> <008201c32092$2ae1a1d0$ec66a8c0@bbarkerxp> In-Reply-To: <008201c32092$2ae1a1d0$ec66a8c0@bbarkerxp> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: localhost.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Bill Barker wrote: >>remm 2003/05/19 14:54:08 >> >> Modified: catalina/src/share/org/apache/catalina/core >> ApplicationContext.java LocalStrings.properties >> StandardContext.java >> Log: >> - Swicth to the "new" mapper for request dispatching. The host mapping > > is > >> copied over for cross context support (I don't see any need to > > optimize this). > >> If I broke stuff, sorry. Let me know. >> >> Revision Changes Path >> 1.11 +78 -28 > > jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/Applicat > ionContext.java > >> Index: ApplicationContext.java >> > + /** >> + * Thread local mapping data. >> + */ >> + private ThreadLocal localMappingData = new ThreadLocal(); >> + >> + >> + /** >> + * Thread local URI message bytes. >> + */ >> + private ThreadLocal localUriMB = new ThreadLocal(); >> + >> + > > > Wouldn't make more sense to have these as Request notes? Especially with > the HTTP/1.1 Connector, the threads are short-lived but the Request gets > reused. I'm not sure I get the short lived argument. Anyway, the idea is that the request is wrapped as soon you go into a dispatcher (well, I guess you can retrieve the one where there's the note by using getRequest and getResponse), so that's why I didn't use a note. It's not too hard to change that. Remy --------------------------------------------------------------------- To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org